QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.11k stars 350 forks source link

Style Update [SpeedDial+SpeedDial:Icons] #2539

Closed ghost closed 6 years ago

nowrep commented 6 years ago

I like it, but there is an issue with loading gif not being properly resized for very small dials (eg. set size to minimum = 100). That applies also to icon/buttons on dials. It's fine those buttons being big for very small dials, but they should also resize when on very big dials (eg. maximum size = 500).

ghost commented 6 years ago

loading gif not being properly resized for very small dials

Hah, looks really funny o_0

Yep, thats my bug. I haven't check this moments. Agree this is realy need some rework. I'll do it tomorrow...

ghost commented 6 years ago

@nowrep Now is the moment to consider merging start page with speeddial?

ghost commented 6 years ago

@cranes-bill it's planned, but not all at once =)

ghost commented 6 years ago

loading gif not being properly resized

Fixed by [[5d76be6]]

It's fine those buttons being big for very small dials, but they should also resize when on very big dials (eg. maximum size = 500).

Fixed by [[a60dd0c]]

Also:

@nowrep what U think about?

nowrep commented 6 years ago

Perfect

ghost commented 6 years ago

@nowrep Pls, update this file in yours repo. https://github.com/Diablopc/qupzilla/commit/6163b0b1b680d656239c8b66949dec25de064a94 It was broken =(

ghost commented 6 years ago

Why the modal dialog overfills the window!? capture du 2018-01-11 08 35 43 And if i enable the bookmarks bar, it's getting badly: capture du 2018-01-11 08 37 40

ghost commented 6 years ago

@cranes-bill already working on this!

nowrep commented 6 years ago

This is a long-standing issue, maybe we can move background selection to second column?

ghost commented 6 years ago

@nowrep I've already added a scrollbar for cases where content can't fit to screen. Commit will be in one hour

nowrep commented 6 years ago

I'd rather have it in two columns instead of adding scrollbars. And also to show the dialogs centered on page.

ghost commented 6 years ago

@nowrep But then we must add a horisontal scroll due to portrait screens...

I have some idea how to decrease vertical size without layout changes... Wait aproximately a hour, i'll try to do that

ghost commented 6 years ago

@nowrep Here is it

Scrollbar appears only if active area lower than 550px. This is enough to not show it on low resolution screens inclusive 768px height

nowrep commented 6 years ago

Ok, that looks fine. Can you also please hide size of pages slider when "change size of pages" is unchecked? It's kind of confusing as the disabled state is not easy to distinguish.

ghost commented 6 years ago

Can you also please hide size of pages slider when "change size of pages" is unchecked?

Sure, it planned. In the nearest future planned to move "Add" button to dial space and restile sliders to common style, also with this i'll hide unused messages =)

nowrep commented 6 years ago

I need your full name, otherwise I can't push this to Falkon repo. And that applies to all following commits too, please commit with full name.

ghost commented 6 years ago

Ou, that's not a problem =) I hope it enough just to add this to my profile?

nowrep commented 6 years ago

Alright, thanks.

I hope it enough just to add this to my profile?

Only if you commit through github webpage. You need to set it in your git config.

ghost commented 6 years ago

You need to set it in your git config.

Ok. It will be done before next commit.

ghost commented 6 years ago

Moved to #2544

ghost commented 6 years ago

@cranes-bill I have Don't close window

it looks weird .... I'm use this option to, but never noticed such behavior... btw try to pick it up from my repo, there was a lot of changes that not yet applied in main repo

nowrep commented 6 years ago

@cranes-bill That has nothing to do with this pull request, you should open separate issue for this.

ghost commented 6 years ago

..., you should open separate issue for this.

That was my initial plan, but due to i'm avoiding of „nonsense issues“, decided posting here. But now, since you tel, i will open a new issue. P.S.: Done