QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.12k stars 347 forks source link

Bad „Speed Dial“ opening #2544

Closed ghost closed 6 years ago

ghost commented 6 years ago

If i have only one page opened in the window, when i close it, the browser should open „Speed Dial“ because i have :ballot_box_withcheck: Don't close window upon closing last tab option set, but it opens an empty „Speed Dial“ instead. (The „Speed Dial“ settings are by default)_. capture du 2018-01-12 22 12 07

ghost commented 6 years ago

Have U tried https://github.com/QupZilla/qupzilla/pull/2539#issuecomment-357351396 ? I tried to reproduce it ... didn't succeed.

nowrep commented 6 years ago

Does it also happen when you try to "close" some qupzilla: internal page like qupzilla:start ?

ghost commented 6 years ago

@nowrep - It does not, i have also tried with qupzilla:about and qupzilla:config

@Diablopc I will try it right after it will be merged.

ghost commented 6 years ago

@nowrep Perhaps QtWebEngine issue, because it is non reproducible with AppImage as well as @Diablopc can't reproduce it?

nowrep commented 6 years ago

What is your QtWebEngine version?

nowrep commented 6 years ago

Please send me terminal output when closing last tab.

diff --git a/src/lib/webengine/webpage.cpp b/src/lib/webengine/webpage.cpp
index 8039bf5e..69a76598 100644
--- a/src/lib/webengine/webpage.cpp
+++ b/src/lib/webengine/webpage.cpp
@@ -377,6 +377,7 @@ void WebPage::setupWebChannelForUrl(const QUrl &url)

 bool WebPage::acceptNavigationRequest(const QUrl &url, QWebEnginePage::NavigationType type, bool isMainFrame)
 {
+    qDebug() << url << type << isMainFrame;
     if (!mApp->plugins()->acceptNavigationRequest(this, url, type, isMainFrame))
         return false;
ghost commented 6 years ago

Sorry for the late response (which is nonsense already ;D), i've had something other to do....! Thanks!