QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.12k stars 348 forks source link

Tabs are misplaced sometimes #2546

Closed NickLion closed 6 years ago

NickLion commented 6 years ago

I haven't found 100% reproducible scenario, but it happens quite often, sometimes tab is shown in wrong place and it's valid place is just empty. Can't reproduce that on Falkon (almost the same as QupZilla 2.1.99). After windows size change or click on empty tab place or changing some tab name everything becomes fine.

screenshot_20180113_121206

openSUSE x86_64, KDE Plasma 5.11.5, Qt 5.10, QupZilla from git 20180109T204351.4d9a9af6.

PS most commonly misplacing happens after tab changes it's title.

nowrep commented 6 years ago

What is your Qt style? Is that Breeze?

NickLion commented 6 years ago

Yes, Breeze.

NickLion commented 6 years ago

Tabs are aligned left everywhere.

nowrep commented 6 years ago

Does it happen also with Windows theme?

NickLion commented 6 years ago

I've checked Fusion, Windows and Kvantum, can't reproduce problem anywhere except Breeze. But also can't reproduce on Falkon with Breeze.

nowrep commented 6 years ago

Hmm that's weird, it should be exactly the same code. Do you also build Falkon from source or use snap?

NickLion commented 6 years ago

Both QupZilla and Falkon are built from git sources in my home repository: https://build.opensuse.org/project/show/home:NickLion:qt5:Unstable And I'm installing them as regular RPM's.

nowrep commented 6 years ago

Your Falkon doesn't have all the recent commits, so that's why you can't reproduce it there. When you update it should be the same as QupZilla.

NickLion commented 6 years ago

Yes, I know. So problem is somewhere in those commits, right?

nowrep commented 6 years ago

Yes. Can you please post your Breeze style config? Animations enabled, animations duration, center tabs (you don't have it afaic see from the screenshot).

NickLion commented 6 years ago

Can't find where they are stored, so just from gui: General: [-] Center tabbar tabs [+] Draw toolbar item separators [+] Draw focus indicator in lists [+] Draw slider tick marks [+] Enable extended resize handles Keyboard accelerators visibility: Show Keyboard Accelerators When Needed Windows' drag mode: Drag from all empty areas

Animations: [+] Enable animations Animations duration: 100ms

Frames: All off

Scrollbars: Top and bottom: No Buttons.


Menu as button on titlebar but off for QupZilla using *.desktop Exec=KDE_NO_GLOBAL_MENU=1 QTWEBENGINE_REMOTE_DEBUGGING=12345 qupzilla %u

NickLion commented 6 years ago

It looks like it have something to tabs without icon. Tab without icon after reload moved roughly twice more (*2) than it should.

NickLion commented 6 years ago

Speed Dial page doesn't look affected though. But http://example.com/ and https://build.opensuse.org/project/show/KDE:Qt5 are.

nowrep commented 6 years ago

If the tab title is too long, it will shift a little to the left when tab icon (loading animation) is hidden to occupy the free space. I don't see a problem here?

nowrep commented 6 years ago

Can you test with Breeze animations disabled?

nowrep commented 6 years ago

Oh, I just finally reproduced it.

NickLion commented 6 years ago

It's fixed, thanks!