QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.11k stars 350 forks source link

SpeedDial: Add searchbar #2556

Closed ghost closed 6 years ago

ghost commented 6 years ago
Martii commented 6 years ago

@Diablopc Best to make a branch on your repository, and ensure that your master is up to date before that so comments don't reappear that aren't applicable here. e.g. mine. Thanks.

ghost commented 6 years ago

Fine, but i think it will look better with square borders (just like the other stuff here).

nowrep commented 6 years ago

Alright, as @Martii said, please make this pull request again from clean branch (it's also good idea to use feature branches for all future pull requests).

Also, instead of configurable engine, let's just make it use default search engine.

ghost commented 6 years ago

@cranes-bill Like this?

@nowrep pull request again from clean branch

Ok

let's just make it use default search engine.

Hmm, idk how much it will be convenient because default search engine available from address bar.

ghost commented 6 years ago

Yes squared :blush:, but that is only in my opinion.