QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.11k stars 350 forks source link

SpeedDial: search #2558

Closed ghost closed 6 years ago

ghost commented 6 years ago

nowrep commented 6 years ago

It looks good, but the configuration needs to be changed.

Either it should offer the same engines as already configured in SearchEnginesManager or just use the default search engine to not complicate things. It can't be like it is now - hardcoded engines.

ghost commented 6 years ago

nowrep commented 6 years ago

The settings have to be in speed dial. Still, I'm okay with it just using default search engine and go without config.

Sorry for not being clear how the settings should be done, next time it would be great if we can discuss it eg. on IRC to prevent this kind of situation.

ghost commented 6 years ago

The settings have to be in speed dial.

I see no reason to return them to SD. In the current state all search settings are displayed in one place

Still, I'm okay with it just using default search engine and go without config.

But while use just default search engine we can't make triple search available( and additional search bar in SD have no reason

next time it would be great if we can discuss it eg. on IRC to prevent this kind of situation.

Hah, yea. Great idea for future))

nowrep commented 6 years ago

All speed dial options are configurable from inside speed dial, so this will not be an exception.

If you want to use multiple search engines, you have search bar that lets you switch engines quickly with up/down keys. This is really not a reason for adding it to speed dial.

Also this use case has another flaw as if you open new tab with speed dial, you will get locationbar automatically focused so in order to switch to speed dial search bar you either need to either click on the search bad with mouse or (if the stars align) press TAB.

So if you really want to have it configurable, it needs to be configurable form speed dial page. That means you need to expose available search engines from C++ to Speed Dial and make the search from C++ too (this is needed even if it is not configurable).

nowrep commented 6 years ago

If this is still relevant, please submit the patch to Falkon.