search

QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.11k stars 350 forks source link

New Windows theme messed in 2.2.5 #2580

Closed smarquespt closed 6 years ago

smarquespt commented 6 years ago

The release 2.2.4 introduced a great new Windows theme. But 2.2.5 has made some regressions because now we have a great interface and bad dialogs. The interface is the same but dialogs made me look like using an older system. Also the menu bar, when hidden, is shrinked on it´s width.

@nowrep Have you made some changes that affect themes? 1 2

nowrep commented 6 years ago

Nothing was changed in themes that could result in this. It looks like issue with Qt 5.10 as 2.2.4 was still using Qt 5.9.

ghost commented 6 years ago

Most likely 5.9 was buggy, because that seems be the „Windows“ style (which is from Windows 95 era :-D). So if the default style for Windows is „Windows“, it should look just like that. My guess is that on the previous version the „Windows style“ was not applied and Qt was used the fallback style (which probably is Fusion).

srazi commented 6 years ago

Here on Win10 it seems OK.

qupzilla qupzilla-win

smarquespt commented 6 years ago

If it matters I'm also using windows 10 but qupzilla is portable.

srazi commented 6 years ago

I can reproduce it by installers from site. The screenshots were from compiled version on my own computer.

@nowrep I copy qupzilla.exe and qupzilla.dll from installers to my compiled version and then again the issue is present. So do you think some libraries were missed from AppVeyor?

nowrep commented 6 years ago

@srazi No idea, might be AppVeyor Qt built without QWindowsVista (or whatever is the "current" windows theme in Qt called) theme? Or windows platform plugin not loading, but in that case the app would not start at all...

srazi commented 6 years ago

Fixed by 03bc614baca1f158e8af0a6b286fa7c62a55b57b

@nowrep Fixed releases based on tag v2.2.5 are available here