search

QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.11k stars 350 forks source link

2.2.5: GIFs cannot be saved to disk #2593

Closed OVasily closed 6 years ago

OVasily commented 6 years ago

Right mouse click on the GIF and picking the menu item "Save Media To Disk" causes QupZilla crash under Win7 32x

OVasily commented 6 years ago

... and using "Save Image as" right mouse button click menu item too. QupZilla crashes.

srazi commented 6 years ago

@OVasily I can not reproduce it on Win10 64Bit. Please give some test links and steps to reproduce it.

OVasily commented 6 years ago

I have no Win10 64x but Win7 32x

Any site. Any image and any GIF. Absolutly any. Even here right click your avatar picture and choose Save image as... menu item. QupZilla crashes.

srazi commented 6 years ago

Unfortunately, I don't have access to a Win7 32bit right now. If you know how to use a debugger on windows (e.g. WinDbg) then maybe stack trace when crash occurs can help us.

OVasily commented 6 years ago

Where can I find the QupZilla debug build with full debug info for Win 32x? I have no possibility to build it myself from source codes.

Release build 2.2.5 for Windows 32x under Delphi debugger gives me Project C:\Program Files\QupZilla\qupzilla.exe faulted with message: 'access violation at 0x6aaf93cb: read of address 0x00000000'. And no call stack (because no debug info in exe-file)

OVasily commented 6 years ago

OK. It seems to be like https://github.com/QupZilla/qupzilla/issues/2590 Maybe. It's about the windows dialog for saving files too.

srazi commented 6 years ago

Well, there is not a debug build available. But WinDbg always give me some info in call stack even with release build.

No, the issue 2590 is not related (but you can find qupzilla.exe and qupzilla.dll of its portable build here. I don't know if they work for you).

Did you try to run QupZilla with a fresh profile?

OVasily commented 6 years ago

(but you can find qupzilla.exe and qupzilla.dll of its portable build here. I don't know if they work for you) And this one pair of exe+dll works fine - no crash! I just rewrite them in %program files%\QupZilla directory and try to reproduce the error. No problem!

Martii commented 6 years ago

@srazi

Unfortunately, I don't have access to a Win7 32bit right now.

See https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ if you do VM's. That SSD toasted itself so I can't test this myself just yet... still recovering.

OVasily commented 6 years ago

I think no need. Latest build (2.2.5.348-master) is OK.

srazi commented 6 years ago

I just rewrite them in %program files%\QupZilla directory and try to reproduce the error. No problem!

Good! :D But, the path %program files%\QupZilla is not writable and the portable version of QupZilla try to create profile directory there. That is impossible.

I think your issue was resolved since you are now using a fresh profile.

OVasily commented 6 years ago

It's all OK with admin rights. It has all write privileges in %PF% I didn't try it under not privileged user.

I think your issue was resolved since you are now using a fresh profile.

Supposed to be. I'll try it when 2.2.6 relase will be done.