QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.12k stars 348 forks source link

can't compile on haiku #290

Closed khallebal closed 12 years ago

khallebal commented 12 years ago

hi there i didn't try to build qupzilla on haiku since the release 1.1.8,until today,unfortunatly some changes seem to halt the compilation for haiku,i hope you have a solution for it,and it comes in a time where haiku users are asking me to submit a binary somewhere for them to test it. here is the output: i hope it'll get fixed soon

network/networkmanager.cpp: In member function 'void NetworkManager::removeLocalCertificate(const QSslCertificate&)': network/networkmanager.cpp:382:22: error: too few arguments to function 'void qWarning(const char, ...)' /boot/common/include/QtCore/qglobal.h:1728:20: note: declared here network/networkmanager.cpp:389:18: error: too few arguments to function 'void qWarning(const char, ...)' /boot/common/include/QtCore/qglobal.h:1728:20: note: declared here network/networkmanager.cpp: In member function 'void NetworkManager::addLocalCertificate(const QSslCertificate&)': network/networkmanager.cpp:416:18: error: too few arguments to function 'void qWarning(const char, ...)' /boot/common/include/QtCore/qglobal.h:1728:20: note: declared here make[2]: ** [../../build/networkmanager.o] Error 1 make[2]: Leaving directory /boot/home/Desktop/QupZilla.git/src/lib' make[1]: *** [sub-lib-make_default-ordered] Error 2 make[1]: Leaving directory/boot/home/Desktop/QupZilla.git/src' make: *\ [sub-src-make_default] Error 2 ~/Desktop/QupZilla.git>

greetings

khaled

nowrep commented 12 years ago

Try it now please.

khallebal commented 12 years ago

Try it now please.

yep it's working again thanks,i've submited a binary for the haiku users on the net,if you want to read reactions click below:

http://haikuware.com/

btw what was the problem?if you don't mind explaining? i noticed that you 've only added yet another #include Qdebug?

nowrep commented 12 years ago

Yes, that was the problem ... Missing header include

khallebal commented 12 years ago

hello admin

it looks like another qtwebkit 2.2.0 issue for haiku? i hope the maintainer of haiku Qt will fix it in the upcoming haiku-alpha4. in the meantime i hope you have key for this one.

../../build/moc_webpage.cpp:86:22: error: 'class WebPage' has no member named 'featurePermissionRequested' ../../build/moc_webpage.cpp:86:118: error: ISO C++ forbids declaration of 'type name' with no type [-fpermissive] ../../build/moc_webpage.cpp:86:118: error: expected '>' ../../build/moc_webpage.cpp:86:118: error: expected '(' ../../build/moc_webpage.cpp:86:118: error: 'Feature' is not a member of 'QWebPage' ../../build/moc_webpage.cpp:86:137: error: expected primary-expression before ')' token make[2]: * [../../build/moc_webpage.o] Error 1 make[2]: Leaving directory `/boot/home/Desktop/nowrep-QupZilla-57d5664/src/lib' make[1]: * [sub-lib-make_default-ordered] Error 2 make[1]: Leaving directory`/boot/home/Desktop/nowrep-QupZilla-57d5664/src' make: *\ [sub-src-make_default] Error 2 ~/Desktop/nowrep-QupZilla-57d5664>

thanks for helping, ps:your browser is becoming populair btw.

greetings.

nowrep commented 12 years ago

Hi, it's probably general QtWebKit 2.2.0 issue. I guess that featurePermission setting was introduced in QtWebKit 2.2.1 .. I will take a look at it when I come home.

nowrep commented 12 years ago

Fixed in dbfc09538c829f19cf2ccabbead73e998c12a6b4

khallebal commented 12 years ago

ok, thanks, i'll give it a shot tonight. is there something nice coming up soon?like a plugin for playing videos?that would be great!

nowrep commented 12 years ago

What exactly do you mean with that plugin ... what videos it should play? QtWebKit can natively play html5 videos itself :-)

khallebal commented 12 years ago

well,i've been trying to play videos on youtube/html5,but it doesn't seem to have support for it,or it's because Qt haiku has an old version of webkit? it always tries to fallback to flash,and this is not available for haiku. you can try disabling flash in windows or linux and test it yourself,i'm curious too?

nowrep commented 12 years ago

Your QtWebKit has to be compiled with video/audio tag support. You can check it at www.html5test.com . In order to have this support, you need to have Phonon backend on Haiku.

Html5 videos are working fine in Linux / doesn't work on Windows (because current QtWebKit is compiled without its support)

khallebal commented 12 years ago

yes,that's what i thought too,the phonon backend is not available in haiku. shame i can not do c++.

2012/3/18, David Rosca reply@reply.github.com:

Your QtWebKit has to be compiled with video/audio tag support. You can check it at www.html5test.com . In order to have this support, you need to have Phonon backend on Haiku.

Html5 videos are working fine in Linux / doesn't work on Windows (because current QtWebKit is compiled without its support)


Reply to this email directly or view it on GitHub: https://github.com/nowrep/QupZilla/issues/290#issuecomment-4559983

khallebal commented 12 years ago

license updated,sorry about that.i hope it's alright now? and thanks alot for adding the haiku binary to your download page.

bye.

2012/3/18, Khaled Berraoui khallebal@gmail.com:

yes,that's what i thought too,the phonon backend is not available in haiku. shame i can not do c++.

2012/3/18, David Rosca reply@reply.github.com:

Your QtWebKit has to be compiled with video/audio tag support. You can check it at www.html5test.com . In order to have this support, you need to have Phonon backend on Haiku.

Html5 videos are working fine in Linux / doesn't work on Windows (because current QtWebKit is compiled without its support)


Reply to this email directly or view it on GitHub: https://github.com/nowrep/QupZilla/issues/290#issuecomment-4559983

khallebal commented 12 years ago

Hello Admin my congrats for the new release, i have 2 requests 1)can you add DESTDIR support to the install routine for distribution purposes? 2)can you make DBUS optional for OSs that don't need it? question: 1)what tools do i need to create a haiku theme (i mean creating icons from scratch)?

greetings.