QupZilla / qupzilla

Cross-platform Qt web browser
http://www.qupzilla.com
GNU General Public License v3.0
1.12k stars 348 forks source link

Both background and foreground tab opening #635

Closed ghost closed 11 years ago

ghost commented 11 years ago

Ability to open links in foreground tab by clicking the contextual menu item (Open Link in New Tab) and in background tab by middle-clicking on the link or vice versa.

Currently both approach do the same thing.

I know there's the option to C+middle-click and such, but using just one hand is a great convenience.

pejakm commented 11 years ago

A behaviour similar to what Opera does. I like the idea.

nowrep commented 11 years ago

It would conflict with "Automatically switch to newly opened tab"

ghost commented 11 years ago

Sorry, but would it be hard to just add another entry to the contextual menu? Like:

"Open link in new background tab"

nowrep commented 11 years ago

There is no reason to have duplicated actions in menus.

ghost commented 11 years ago

All right, what if I've just one hand and would like to open links sometime in background and other times in foreground tab?

nowrep commented 11 years ago

Well, but you are right .. I can add this functionality to some actions (like open liink in new tab in webview's context menu). But not for all.

ghost commented 11 years ago

Fine, just for the links, that's all. Just like in Opera. Thanks.

ghost commented 11 years ago

I'll shut up after this, but just to clarify my point: Instead of the current contextual menu itme (open link in new tab), you can put these two:

open link in new foreground tab open link in new background tab

nowrep commented 11 years ago

Nope. Left click = foreground tab Middle click = background tab

ghost commented 11 years ago

Yes, that's even better!

pejakm commented 11 years ago

After this commit, if I have "Automatically switch to newly opened tab" option on, middle click on a link will also open the tab in the foreground.

nowrep commented 11 years ago

@pejakm It was always acting this way. This commit (nor any other recent commits) didn't change it.

pejakm commented 11 years ago

Well, it sounds unlogical to me for a middleclick to open tab in foreground...

nowrep commented 11 years ago

It just follows your setting to "automatically switch to newly opened tab"

sys9kdr commented 11 years ago

"automatically switch to newly opened tab" means open in foreground ALL tabs. Some major Windows browsers open tabs foreground by middle click as well as QupZilla. Lunascape, Slim and more browsers open tab this way. I think this is logical way.

pejakm commented 11 years ago

Then what was this feature request about? This user asked for actions to "Open in new foreground tab" and "Open in new background tab". I thought this option ("automatically switch...") implements this for just one menu action ("Open in new tab" opens in foreground if "Automatically switch ..." is on).

nowrep commented 11 years ago

No, it wasn't. But also 3eae0bf didn't change the behaviour you are describing (it's been there for at least half of year)

ghost commented 11 years ago

This is getting funny!

Currently if "Auto switch" is on, both left click and middle click opens links in foreground, but from now on (hopefully?!) left click will open in foreground and middle click in background. Right?

nowrep commented 11 years ago

Aha ... this issue was about opening new tabs from context menu (not middle click on link). So now: right click on link ->

left click on "open link in new tab" opens it in user prefered method middle click on "open link in new tab" opens it in reversed user prefered method

while user prefered method may be background or foreground tab. (according to automatically switch to newly opened tabs settings)

ghost commented 11 years ago

Yes, sorry; I was trying to say the same thing, but forgot about the first right clik step. Thanks; fine.