Quplet / Qu-Enchantments

Me just adding whatever enchantments I think is cool that fit with vanilla Minecraft.
Apache License 2.0
2 stars 7 forks source link

Rune breakOnNoDurability not working in 1.20.4 #17

Open BioMasterZap opened 2 months ago

BioMasterZap commented 2 months ago

Not sure if the 1.20.4 version is still being maintained/updated, but for Qu Enchantments v1.3.8, I noticed that Runes don't seem to break on durability loss regardless of the config setting. When I have "[runeOptions] breakOnNoDurability = true", they will drain to 0 durability where they can regen as normal.

For context, I grabbed a Rune from the creative menu, usually 1 or 2 since lower durability, put all 3 blessings on it, then switched to Survival and held it until the durability ran out. I did confirm this in a test profile with only Enchantments v1.3.8 and Fabric API v0.97.1 with breakOnNoDurability on true, then false, then true again and in all instances the rune only drained to 0.

This might have already fixed with the rewrites in the 1.20.6 version, but figured I probably should bring it up incase it is still an issue and/or if it would be easy to fix for 1.20.4.