search

Quramy / jest-prisma

Jest environment for integrated testing with Prisma client
MIT License
266 stars 15 forks source link

Adds back await to teardown #151

Closed danielpowell4 closed 3 months ago

danielpowell4 commented 3 months ago

disconnect needs to be await'd per examples here: https://www.prisma.io/docs/orm/prisma-client/setup-and-configuration/databases-connections/connection-management#calling-disconnect-explicitly

As far as I can tell in github's git blame this was removed with this commit: https://github.com/Quramy/jest-prisma/commit/5e19e90b1b6161fb8e9b348bc6092cdb5c316b65

Unsure how to run any tests in development so likely good to spot check before merging and cutting a new version

Thanks again for all the work here!

Think might be related to https://github.com/Quramy/jest-prisma/issues/98

danielpowell4 commented 3 months ago

@Quramy just pinging to see if you saw this

Quramy commented 3 months ago

@danielpowell4

Sorry for my late reply and thanks for your PR . :bow: I published this as v1.8.1

(And I don't remember why I removed await https://github.com/Quramy/jest-prisma/commit/5e19e90b1b6161fb8e9b348bc6092cdb5c316b65 )