Quramy / lerna-yarn-workspaces-example

How to build TypeScript mono-repo project with yarn and lerna
MIT License
898 stars 94 forks source link

discrepancy between readme and code #19

Open davidmoshal opened 4 years ago

davidmoshal commented 4 years ago

Hi, have been looking at this code, seems to work, though there are significant differences between the readme and the codebase.

(1) the readme describes use of tsconfig @paths, yet none of the tsconfig files use this?

(2) instead the packages seem to be mapped as package.json devDependencies, ie; nothing to do with tsconfig ?

(3) the lone tsconfig.json file is not referenced by any other config files, instead they all reference the tsconfig.settings.json file.

So, it seems that the readme describes use of tsconfig references and paths, yet the code (currently) actually uses package.json devDependency references.

What am I missing here? Given that your solution actually works, what are you thoughts on which way to go?