QutEcoacoustics / workbench-client

workbench-client: a client side browser application for interacting with acoustic workbenches

Other

8 stars 1 forks source link

Fixed title querying uninitialized Harvet model #2005

Closed hudson-newey closed 1 year ago

hudson-newey commented 1 year ago

Fixes: #2000

Fixed title querying uninitialized Harvet model

Fix regression in Harvest naming which produced JavaScript runtime errors from querying uninitialised Harvest model.

Changes

The title component will no longer try to render the Harvest name if the Harvest model is undefined.

Issues

2000

Visual Changes

na.

Final Checklist

[x] Assign reviewers if you have permission
[x] Assign labels if you have permission
[x] Link issues related to PR
[x] Ensure project linter is not producing any warnings (npm run lint)
[x] Ensure build is passing on all browsers (npm run test:all)
[x] Ensure CI build is passing
[x] Ensure docker container is passing (docs)

github-actions[bot] commented 1 year ago

Size Change: +69 B (0%)

Total Size: 2.67 MB

Filename	Size	Change
`dist/workbench-client/browser/main.****************.js`	845 kB	+26 B (0%)
`dist/workbench-client/server/main.js`	1.77 MB	+43 B (0%)

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `dist/workbench-client/browser/assets/environment.json` | 555 B | | `dist/workbench-client/browser/index.html` | 3.83 kB | | `dist/workbench-client/browser/manifest.json` | 150 B | | `dist/workbench-client/browser/polyfills.****************.js` | 12.5 kB | | `dist/workbench-client/browser/runtime.****************.js` | 648 B | | `dist/workbench-client/browser/styles.****************.css` | 37.4 kB |

_{compressed-size-action}

github-actions[bot] commented 1 year ago

Unit Test Results

        6 files         6 suites 13m 36s :stopwatch: 17 400 tests 16 836 :heavy_check_mark: 564 :zzz: 0 :x: 17 496 runs 16 932 :heavy_check_mark: 564 :zzz: 0 :x:

Results for commit d056a371.