QutEcoacoustics / workbench-client

workbench-client: a client side browser application for interacting with acoustic workbenches

Other

8 stars 1 forks source link

Fixed deprecated usage of RXJS subscribe #2039

Closed hudson-newey closed 1 year ago

hudson-newey commented 1 year ago

Fixed depricated usage of RXJS subscribe

What is the purpose of this PR?

Changes

Changes rxjs subscribe methods to use observable in replacement of deprecated usage of multiple parameters
Fixes subscribe in the Harvest title component not unsubscribing

Problems

None

Issues

Fixes: #1765

Visual Changes

No visual changes

Final Checklist

[x] Assign reviewers if you have permission
[x] Assign labels if you have permission
[x] Link issues related to PR
[x] Ensure project linter is not producing any warnings (npm run lint)
[x] Ensure build is passing on all browsers (npm run test:all)
[x] Ensure CI build is passing
[ ] Ensure docker container is passing (docs)