QutEcoacoustics / workbench-client

workbench-client: a client side browser application for interacting with acoustic workbenches
Other
8 stars 1 forks source link

Added creator/updated cards to Harvest pages #2075

Closed hudson-newey closed 1 year ago

hudson-newey commented 1 year ago

Add creator/updater cards to harvest pages

I found a bug in my implementation after I opened this PR. Not ready for review

The current created by / updated by cards refer to the project. These should instead refer to the harvest.

Changes

Problems

None

Issues

2060

Visual Changes

image Harvest list page with "Creator" column and no "Created by / Updated by" menu cards

image Harvest details page with "Created by / Updated by" menu card and fixed typo

Final Checklist

github-actions[bot] commented 1 year ago

Size Change: +226 B (0%)

Total Size: 2.68 MB

Filename Size Change
dist/workbench-client/browser/main.****************.js 848 kB +119 B (0%)
dist/workbench-client/server/main.js 1.78 MB +107 B (0%)
ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `dist/workbench-client/browser/assets/environment.json` | 555 B | | `dist/workbench-client/browser/index.html` | 3.83 kB | | `dist/workbench-client/browser/manifest.json` | 150 B | | `dist/workbench-client/browser/polyfills.****************.js` | 12.5 kB | | `dist/workbench-client/browser/runtime.****************.js` | 648 B | | `dist/workbench-client/browser/styles.****************.css` | 37.4 kB |

compressed-size-action

github-actions[bot] commented 1 year ago

Unit Test Results

         6 files           6 suites   14m 22s :stopwatch: 20 028 tests 19 452 :heavy_check_mark: 576 :zzz: 0 :x: 20 136 runs  19 560 :heavy_check_mark: 576 :zzz: 0 :x:

Results for commit 04c08a2f.

:recycle: This comment has been updated with latest results.

hudson-newey commented 1 year ago

Blocked by #2076

hudson-newey commented 1 year ago

With the ngx-datatable props fix we found on Tuesday, this PR is ready to merge. I will be merging shortly