hudson-newey commented 1 year ago

Upgrade Angular and Its Dependencies

We have several outdated dependencies, this pull request updates all the dependencies

You can see all the breaking changes due to our migration from ngx 14 -> 16 here

Although, a lot of tests were modified due to breaking changes in ng-mocks (see below)

Changes

Added tests for time.component.ts
Fixed bug in time.component.ts where errors weren't shown if a propper time wasn't input first
Commented out empty TODO tests (empty tests now causes a Karma error)
When fetching an element mocked with ng-mock, we can no longer fetch it with it's mocked instance, you now have to fetch it using the component which was mocked. This caused tests to break after upgrading
ng-mock MockRender now requires an empty object as the second parameter
Ran formatter on all files (this was automatically done by the ng update command)
We now use the "declare" keyword in certain places when overriding abstract class methods
Importing ngx-datatable styles is now done through the @use keyword instead of @import
Using the ~ as an alias for node_modules is no longer supported for scss imports. node_modules was added as a default import location for scss imports, and the use of the "~" was removed
Changed builder to es-build 🥳
Angular testing now recognises .spec.ts as the file extension for test files. This assertion was therefore removed from our test.ts
Stronger type checking for ng-template's required me to update the Typeahead input template output context to include the search term & term formatter
The collapsed property is no longer exposed in ngx-boostrap DOM elements. This required tests to be changed to query classess not DOM object properties
Added "work in progress" menu item predicate to add better semantic meaning as to why only admins can view a menu item
Officially dropped support for kaios, and opera mini browsers (as they do not support ES6 and are mobile browsers with small market share)
RouterLinkWithHerf is no longer implemented in Angular and all functionality has been transfered to RouterLink. Therefore, I've changed all instances of RouterLinkWithHerf with RouterLink (ensuring that I don't break strong route)
In cards.component.spec.ts, the CardsComponent was being mocked twice each test, causing errors
TypeScript return type of NodeJS setInterval was renamed to NodeJS.Timeout
"plugin:@angular-eslint/ng-cli-compat" es-lint extensions are now deprecated (has been merged with @angular-eslint/recommended)
eslint plugin "plugin:@angular-eslint/ng-cli-compat--formatting-add-on" was deprecated and merged with @angular-eslint/recommended
Upgraded to NodeJS version 18 (LTS) (in docker container and dev environment)

Problems

None

Issues

Fixes: #2077

Visual Changes

None

Final Checklist

[x] Assign reviewers if you have permission
[x] Assign labels if you have permission
[x] Link issues related to PR
[x] Ensure project linter is not producing any warnings (npm run lint)
[x] Ensure build is passing on all browsers (npm run test:all)
[x] Ensure CI build is passing
[x] Ensure docker container is passing (docs)

github-actions[bot] commented 1 year ago

Size Change: -570 kB (-17%) 👏

Total Size: 2.88 MB

Filename	Size	Change
`dist/workbench-client/browser/index.html`	4.1 kB	+268 B (+7%)	🔍
`dist/workbench-client/browser/main.****************.js`	0 B	-1.15 MB (removed)	🏆
`dist/workbench-client/browser/polyfills.****************.js`	0 B	-12.5 kB (removed)	🏆
`dist/workbench-client/browser/runtime.****************.js`	0 B	-715 B (removed)	🏆
`dist/workbench-client/browser/styles.****************.css`	0 B	-37.4 kB (removed)	🏆
`dist/workbench-client/server/main.js`	1.77 MB	-479 kB (-21%)	🎉
`dist/workbench-client/browser/chunk-7SGCG2G3.js`	1.08 kB	+1.08 kB (new file)	🆕
`dist/workbench-client/browser/main.********.js`	1.06 MB	+1.06 MB (new file)	🆕
`dist/workbench-client/browser/polyfills.********.js`	12.2 kB	+12.2 kB (new file)	🆕
`dist/workbench-client/browser/styles.********.css`	32.3 kB	+32.3 kB (new file)	🆕
`dist/workbench-client/server/776.js`	4.2 kB	+4.2 kB (new file)	🆕

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `dist/workbench-client/browser/assets/environment.json` | 555 B | | `dist/workbench-client/browser/manifest.json` | 150 B |

_{compressed-size-action}

github-actions[bot] commented 1 year ago

Unit Test Results

        6 files         6 suites 10m 45s :stopwatch: 20 694 tests 20 070 :heavy_check_mark: 624 :zzz: 0 :x: 20 802 runs 20 178 :heavy_check_mark: 624 :zzz: 0 :x:

Results for commit fa2d150f.

:recycle: This comment has been updated with latest results.

hudson-newey commented 1 year ago

I've done some testing using staging data and there are no regressions

Given that this PR will impact almost every function of the web client, are you all good for me to merge after CI passes?

QutEcoacoustics / workbench-client