Closed hudson-newey closed 7 months ago
Size Change: +2.23 kB (0%)
Total Size: 2.91 MB
Filename | Size | Change |
---|---|---|
dist/workbench-client/browser/index.html |
4.1 kB | -1 B (0%) |
dist/workbench-client/browser/main.********.js |
1.07 MB | +955 B (0%) |
dist/workbench-client/server/main.js |
1.79 MB | +1.27 kB (0%) |
6 files 6 suites 9m 19s :stopwatch: 23 274 tests 22 650 :heavy_check_mark: 624 :zzz: 0 :x: 23 496 runs 22 872 :heavy_check_mark: 624 :zzz: 0 :x:
Results for commit 69d41092.
:recycle: This comment has been updated with latest results.
Noticing lots of line break churn. Did our line length settings change?
Our line length settings have not changed. My best guess is that the formatter hasn't run on these files before
Display warning message for "bad" website status
At the moment, when the server is down / has partial services, the only way users can diagnose the issue as a server side issue is by going to https://www.ecosounds.org/status.
Because this is unintuitive to some users, we should surface the issue sooner as a server issue by adding warnings showing that the service the user is trying to use is non-functional.
Important note: I am not displaying an error indicator in the navbar for a timeout error.
This is because:
Changes
<hr>
at the base of the menu links container (even when there are no widgets)Problems
None
Issues
Fixes: #2102
Visual Changes
"bad"
)<hr>
element at the bottom of menu links without widgetsFinal Checklist
npm run lint
)npm run test:all
)