Closed hudson-newey closed 7 months ago
Size Change: +6.29 kB (0%)
Total Size: 3.01 MB
Filename | Size | Change | |
---|---|---|---|
dist/workbench-client/browser/index.html |
4.71 kB | +2 B (0%) | |
dist/workbench-client/browser/main-ZSFC3WLT.js |
0 B | -1.07 MB (removed) | π |
dist/workbench-client/server/main.js |
1.87 MB | +3.4 kB (0%) | |
dist/workbench-client/browser/main-V4H2UQGM.js |
1.07 MB | +1.07 MB (new file) | π |
βββββββββ6 filesβββββββββββ6 suitesβββ8m 38s :stopwatch: 23β220 testsβ22β704 :heavy_check_mark:β516 :zzz:β0 :x: 23β442 runsββ22β926 :heavy_check_mark:β516 :zzz:β0 :x:
Results for commit a4e7e550.
Add signals to date/time components
With the addition of signals into Angular, we can improve the change detection of the date/time components to be more efficient.
This PR changes the date/time component to use signals over
zone.js
Changes
17.0.9
->17.1.2
TestBed
instead of the ng-neat testbed. This is because (at the moment of writing) ng-neatsetInput
doesn't correctly handle signal inputstoHaveExtactTrimmedText
is nowexpect(foo.textContent.trim()).toBe("xyz")
)time-since.component.ts
now uses a variablenow
instead ofDateTime.now()
to prevent time drift withinupdate()
functiondatetime-example.component.ts
now uses a property for thefakeDateTime
that sets the zone in advanceProblems
We still have to implement the date/time components on relevant pages
Issues
Fixes: #2114
Visual Changes
None
Final Checklist
npm run lint
)npm run test:all
)