Closed hudson-newey closed 6 months ago
Size Change: +360 B (0%)
Total Size: 3.01 MB
Filename | Size | Change | |
---|---|---|---|
dist/workbench-client/browser/main-V4H2UQGM.js |
0 B | -1.07 MB (removed) | π |
dist/workbench-client/server/main.js |
1.87 MB | +256 B (0%) | |
dist/workbench-client/browser/main-STQ7JKIV.js |
1.07 MB | +1.07 MB (new file) | π |
βββββββββ6 filesβββββββββββ6 suitesβββ8m 1s :stopwatch: 23β154 testsβ22β638 :heavy_check_mark:β516 :zzz:β0 :x: 23β376 runsββ22β860 :heavy_check_mark:β516 :zzz:β0 :x:
Results for commit 71c1f516.
:recycle: This comment has been updated with latest results.
For this case we can probably just add a (<baw-datetime-since ...></baw-datetime-since>)
afterwards to achieve a similar effect to what was there.
For this case we can probably just add a
(<baw-datetime-since ...></baw-datetime-since>)
afterwards to achieve a similar effect to what was there.
My hesitation about this format was that we would have two tooltips that shouw the exact same information (one for the baw-datetime
and one for the baw-time-since
).
However, by adding a hasTooltip
input signal to the abstract-template.component
, we are able to conditionally hide the baw-time-since
tooltip (since it give the same information as the baw-datetime
tooltip)
For this case we can probably just add a
(<baw-datetime-since ...></baw-datetime-since>)
afterwards to achieve a similar effect to what was there.My hesitation about this format was that we would have two tooltips that shouw the exact same information (one for the
baw-datetime
and one for thebaw-time-since
).However, by adding a
hasTooltip
input signal to theabstract-template.component
, we are able to conditionally hide thebaw-time-since
tooltip (since it give the same information as thebaw-datetime
tooltip)
I don't think we need to worry honestly. The tooltips add context to the text they wrap. They're not on by default.
If we really wanted to solve this we might add another datetime control or option to show date and time-since in one component. But as it stands we have exactly one example so that would be premature optimization - as would be adding an option to hide the tooltip
Implement Date/Time components
With the functionality of the date/time components now complete, we should implement them on the relevant pages to standardize formatting and localization.
This fixes a common and re-occuring point of user friction.
Changes
toRelative
pipe and associated testsbaw-zoned-datetime
andbaw-duration
baw-duration
for the "duration" columnbaw-datetime
for the "created" columnbaw-duration
for recording duration in the tablebaw-zoned-datetime
(localized to site timezone) for "recorded" columnbaw-datetime
for "Created At" columnbaw-time-since
component for the "last updated" columnbaw-datetime
) for generated date/timebaw-duration
for search range tablebaw-time-since
baw-zoned-datetime
baw-time-since
baw-duration
component for the "Duration" columnbaw-time-since
component for the "Uploaded [at]" columnbaw-datetime
andbaw-duration
components)baw-datetime
(since this is predominantly used for "created at" fields and it retains the existing behavior)Bug fixes
abtract-template.component.ts
added whitespace before and after the datetime. This lead to incorrectly formatted documents and has been fixedProblems
None
Issues
Fixes: #345 Fixes: #346
Visual Changes
The "created by" and "updated by" shields widget (in the menu bar) now uses the two largest units (to keep consistent with the rest of the relative duration formats in the website)
The audio recordings page now shows fractional seconds
Harvest ETA component now uses the
<baw-time-since>
and<baw-duration>
componentsThis means that I have had to re-order some words above the progress bar
This also removes an additional RxJS observable (potentially improving performance)
The "My Sites" page now uses the two largest units in the "Last Modified" column
Recent annotations and recent audio recordings now show the two largest units
The audio recording details page has new changed date/time formats
Unshown visual changes
Final Checklist
npm run lint
)npm run test:all
)