QutEcoacoustics / workbench-client

workbench-client: a client side browser application for interacting with acoustic workbenches
Other
8 stars 1 forks source link

Modals remain open after navigating away from host pages #2138

Open hudson-newey opened 4 months ago

hudson-newey commented 4 months ago

Describe the bug It is possible to have a modal open for a page that is no longer active by navigating back in browser history while a modal is open.

To Reproduce Steps to reproduce the behavior:

  1. Go to ecosounds.org/projects/1134
  2. Click on "DBKD"
  3. Click on "Download Annotations" in the primary menu bar
  4. Click the "Back" arrow in your browsers navigation bar
  5. Observe that the modal is still open even when you, but you are on the "Black-throated finch" projects page

Expected behavior

The modal should close when the page location is no longer the modals host

Desktop (please complete the following information):