hudson-newey commented 2 weeks ago

Association decorators should not show error notifications

This pull request creates a new association injector that can be used to inject different options into the baw-api.service.ts

Changes

Adds an association-injector.service. This injector used in the abstract model constructor
Adds injectable BawAptOptions to the baw-api.service
Fixes a bug where the associations would throw errors (e.g. the audio recording list page if not logged in)
Fixes some minor formatting issues
Corrects TypeScript typing for ServiceToken.kind
Improves the TypeScript typing of ServiceProviders and AbstractDataModel
Add missing PageInfo tests to annotation search page

Issues

Fixes: #1967

Final Checklist

[ ] Assign reviewers if you have permission
[x] Assign labels if you have permission
[x] Link issues related to PR
[x] Ensure project linter is not producing any warnings (npm run lint)
[x] Ensure build is passing on all browsers (npm run test:all)
[x] Ensure CI build is passing
[x] Ensure docker container is passing (docs)

github-actions[bot] commented 2 weeks ago

Size Change: +580 B (+0.02%)

Total Size: 3.59 MB

Filename	Size	Change
`dist/workbench-client/browser/index.html`	4.79 kB	+2 B (+0.04%)
`dist/workbench-client/browser/main-2BSDE7KO.js`	0 B	-1.13 MB (removed)	🏆
`dist/workbench-client/server/main.js`	1.94 MB	+326 B (+0.02%)
`dist/workbench-client/browser/main-SHI5ZZQN.js`	1.13 MB	+1.13 MB (new file)	🆕

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `dist/workbench-client/browser/@ecoacoustics/web-components/_commonjsHelpers-BVfed4GL.js` | 432 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/abstractComponent-gI12hGSz.js` | 6.49 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/assets/buffer-builder-processor-BhnxGUx8.js` | 1.16 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/assets/high-accuracy-time-processor-BevUJNwo.js` | 354 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/attributes-DayhhJl-.js` | 313 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/class-map-BJ2wQJjp.js` | 675 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/classification-syqJf8YO.js` | 125 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/colors-DMCqRncD.js` | 328 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/components.js` | 116 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/axes.js` | 3.19 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/classification.js` | 1.77 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/data-source.js` | 63.3 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/decision.js` | 1.25 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/help-dialog.js` | 2.61 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/helpers/constants/contextTokens.js` | 209 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/indicator.js` | 1.12 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/info-card.js` | 1.59 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/logger.js` | 418 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/media-controls.js` | 38.2 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/progress-bar.js` | 1.13 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/spectrogram.js` | 167 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/verification-grid-settings.js` | 1.48 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/verification-grid-tile.js` | 3.55 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/verification-grid.js` | 387 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/components/verification.js` | 1.3 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/consume-D2RSb1qY.js` | 614 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/context-request-event-Bc4uem__.js` | 239 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/custom-elements.json` | 9.59 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/decision-Btskh9bB.js` | 202 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/decisionColors-DNuXUVq4.js` | 3.84 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/decorators-zsXcIcN9.js` | 516 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/directive-B76A7YXI.js` | 343 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/directive-helpers-DAca9yBy.js` | 638 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/if-defined-YSzpD1Zv.js` | 178 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/keyboard-MZyub3T-.js` | 117 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/lit-element-CNpxFSzF.js` | 6.77 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/map-D8heArFD.js` | 184 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/property-cctOu2Be.js` | 639 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/provide-Ce8Vz0mw.js` | 1.18 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/query-sbFTBDPt.js` | 340 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/signal-watcher-CbQ3umdl.js` | 377 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/signals-core.module-BUxpRF5s.js` | 1.59 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/state-DJrhCpxL.js` | 203 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/userAgent-CdrtNGdV.js` | 1.04 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/utilities-C38J31_r.js` | 432 B | | `dist/workbench-client/browser/@ecoacoustics/web-components/verification-grid-DnTXiJ40.js` | 12.1 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/watch-BnoWuiCc.js` | 1.02 kB | | `dist/workbench-client/browser/@ecoacoustics/web-components/when-CDK1Tt5Y.js` | 168 B | | `dist/workbench-client/browser/assets/environment.json` | 555 B | | `dist/workbench-client/browser/assets/test-assets/index.html` | 21 B | | `dist/workbench-client/browser/manifest.json` | 147 B | | `dist/workbench-client/browser/polyfills-C5CKP5CH.js` | 12.4 kB | | `dist/workbench-client/browser/styles-ETV6J7SM.css` | 39.6 kB | | `dist/workbench-client/server/952.js` | 4.21 kB |

_{compressed-size-action}

github-actions[bot] commented 2 weeks ago

Unit Test Results

        4 files         4 suites 7m 42s :stopwatch: 16 052 tests 15 644 :heavy_check_mark: 408 :zzz: 0 :x: 16 200 runs 15 792 :heavy_check_mark: 408 :zzz: 0 :x:

Results for commit 615fa3b7.

:recycle: This comment has been updated with latest results.

QutEcoacoustics / workbench-client