Quuxplusone / LLVMBugzillaTest

0 stars 0 forks source link

Exception Table out-of-range but still keep walking #14332

Closed Quuxplusone closed 11 years ago

Quuxplusone commented 11 years ago
Bugzilla Link PR14312
Status RESOLVED FIXED
Importance P normal
Reported by WenHan Gu (wenhan.gu@gmail.com)
Reported on 2012-11-10 02:08:49 -0800
Last modified on 2012-11-13 07:20:45 -0800
Version unspecified
Hardware Other Linux
CC pawel@32bitmicro.com, wenhan.gu@gmail.com
Fixed by commit(s)
Attachments eh_table_out_of_range.patch (985 bytes, text/plain)
Blocks
Blocked by
See also
Hi all,

When I test this test case, I found it will keep walking through exception
table entry even though it should stop and terminate.
http://www.doc.ic.ac.uk/~awl03/cgi-bin/trac.cgi/miro/browser/trunk/gcc/gcc/testsuite/g%2B%2B.old-deja/g%2B%2B.mike/eh23.C

The reason is that the exception table didn't encode this into one entry, but,
libcxxabi always trust it can find the one. (i.e., while (true) loop)

I've tested on ARM and x86, and both have this bug.
I trust other platforms have this problem too.
This may cause nothing error, infinite loop, or other errors, just depending on
the next upcoming entry.

Thanks.
Quuxplusone commented 11 years ago

Attached eh_table_out_of_range.patch (985 bytes, text/plain): Fix while loop condition

Quuxplusone commented 11 years ago

Thanks for your persistence on this one. Your patch committed revision 167733.

Please also send a patch for CREDITS.TXT.

Quuxplusone commented 11 years ago
Hi Howard,

Big thanks for your help!
This is the patch for CREDITS.TXT. Thanks!

Index: CREDITS.TXT
===================================================================
--- CREDITS.TXT (revision 167830)
+++ CREDITS.TXT (working copy)
@@ -28,3 +28,7 @@
 E: erik.olofsson@hansoft.se
 E: erik@olofsson.info
 D: Minor patches and fixes
+
+N: Nowar Gu
+E: wenhan.gu@gmail.com
+D: Minor patches and fixes

(In reply to comment #2)
> Thanks for your persistence on this one.  Your patch committed revision
167733.
>
> Please also send a patch for CREDITS.TXT.