search

Quuxplusone / LLVMBugzillaTest

0 stars 0 forks source link

Replace <strsream>/strstream with <sstream>/stringstream #23829

Open Quuxplusone opened 9 years ago

Quuxplusone commented 9 years ago
Bugzilla Link PR23830
Status NEW
Importance P enhancement
Reported by Eugene Zelenko (eugene.zelenko@gmail.com)
Reported on 2015-06-12 11:54:23 -0700
Last modified on 2016-01-21 18:56:14 -0800
Version unspecified
Hardware All All
CC alexfh@google.com, djasper@google.com, edwin.vane@intel.com, klimek@google.com, legalize@xmission.com
Fixed by commit(s)
Attachments
Blocks
Blocked by
See also

I think will be good idea to add replacement of /strstream with /stringstream.

Quuxplusone commented 9 years ago

Should be part of modernize part of Clang-tidy, since Clang-modernize is deprecated.

Quuxplusone commented 8 years ago

Doesn't this check have to do more than just replace the names of the included headers?

Aren't there also changes in the class names?

Besides the different class names, are their member functions completely compatible?

Quuxplusone commented 8 years ago 
(In reply to comment #2)
> Doesn't this check have to do more than just replace the names of the
> included headers?
>
> Aren't there also changes in the class names?
>
> Besides the different class names, are their member functions completely
> compatible?

I'm not completely sure, but simple replacements worked on my code base.