-fopenmp-use-tls causes two regressions in OpenMP3.1_Validation on x86_64-apple-darwin14

[Quuxplusone]

Bugzilla Link	PR24120
Status	RESOLVED FIXED
Importance	P normal
Reported by	Jack Howarth (howarth.mailing.lists@gmail.com)
Reported on	2015-07-14 12:53:47 -0700
Last modified on	2015-07-27 11:49:20 -0700
Version	trunk
Hardware	Macintosh MacOS X
CC	a.bataev@hotmail.com, hfinkel@anl.gov, llvm-bugs@lists.llvm.org, samuelfantao@gmail.com
Fixed by commit(s)
Attachments
Blocks
Blocked by
See also

At r242152, when running the OpenMP3.1_Validation test suite with -
fopenmp=libomp -fopenmp-use-tls on x86_64-apple-darwin14, two regressions occur
in...

Testing for "omp_parallel_copyin":
Generating sources .............. success
Compiling soures ................ success
Running test with 8 threads ..... failed 100% of the tests
+ orphaned mode:
Generating sources .............. success
Compiling soures ................ success
Running test with 8 threads ..... failed 100% of the tests

[Quuxplusone]

There isn't much information in bin/c/ctest_omp_parallel_copyin.log or bin/c/orph_test_omp_parallel_copyin.log as all 20 tests in each case simply show...

Error: Test failed.

and finally...

Directive failed the test 20 times out of 20. 0 were successful

[Quuxplusone]

The reason for the problem is that the copy concerning the copyin clause is
done by the thread that is spawned instead of being passed to the spawned
threads by the master thread.

I should be able to send a fix for review soon.

Thanks for reporting the issue!
Samuel

[Quuxplusone]

This should be fixed by r243277. Please verify.