Phabricator produces broken patches when the patches include file moves


Bugzilla Link	PR24510
Status	NEW
Importance	P normal
Reported by	Duncan (dexonsmith@apple.com)
Reported on	2015-08-19 16:57:01 -0700
Last modified on	2015-08-19 19:56:12 -0700
Version	unspecified
Hardware	PC All
CC	chandlerc@gmail.com, geek4civic@gmail.com, llvm-bugs@lists.llvm.org
Fixed by commit(s)
Attachments	`D12133.32497.patch` (23970 bytes, text/plain)
Blocks
Blocked by
See also

Created attachment 14749
broken patch from phabricator

D12133 (must be a URL for that somewhere) has a broken patch; Chandler suspects
the cause is something to do with the "diff-construction logic that we added to
make inline comments look right".

Here's what I get when applying the attached patch to r245506:
--
$ patch -p0 <
/Users/dexonsmith/Library/Containers/com.apple.mail/Data/Library/Mail\
Downloads/0174B486-F815-4954-A249-F6C6DF1D10CD/D12133.32497.patch
patching file lib/Transforms/ObjCARC/PtrState.h
patching file lib/Transforms/ObjCARC/ObjCARCOpts.cpp
patching file lib/Transforms/ObjCARC/CMakeLists.txt
can't find file to patch at input line 52
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: lib/Analysis/ObjCARCInstKind.cpp
|===================================================================
|--- lib/Analysis/ObjCARCInstKind.cpp
|+++ lib/Analysis/ObjCARCInstKind.cpp
--------------------------
File to patch:
--

Quuxplusone / LLVMBugzillaTest

Phabricator produces broken patches when the patches include file moves #24509