search

Quuxplusone / LLVMBugzillaTest

0 stars 0 forks source link

PowerPC64 isn't building builtins library #27661

Open Quuxplusone opened 8 years ago

Quuxplusone commented 8 years ago
Bugzilla Link PR27662
Status NEW
Importance P normal
Reported by Anton Blanchard (anton@samba.org)
Reported on 2016-05-05 23:03:00 -0700
Last modified on 2018-06-13 12:30:29 -0700
Version unspecified
Hardware PC Linux
CC ehsanamiri@gmail.com, hfinkel@anl.gov, kit.barton@gmail.com, llvm-bugs@lists.llvm.org, nemanja.i.ibm@gmail.com, vitalybuka@google.com
Fixed by commit(s)
Attachments compiler-rt.patch (934 bytes, text/plain)
Blocks
Blocked by
See also 
Created attachment 16314
Build builtins library on powerpc64 and powerpc64le

When bootstrapping rust, I noticed the builtins library wasn't being built for
powerpc64 and powerpc64le.

Attached is a simple patch to enable it, is there any reason it was disabled?
Quuxplusone commented 8 years ago

Attached compiler-rt.patch (934 bytes, text/plain): Build builtins library on powerpc64 and powerpc64le

Quuxplusone commented 8 years ago

To be clear, when you do this, all of the regression tests pass? If so, you should probably send this to llvm-commits for review.

Quuxplusone commented 8 years ago 
I double checked my results, and it seems like the builtin tests aren't getting
run at all:

# BlocksRuntime and builtins testsuites are not yet ported to lit.
# add_subdirectory(BlocksRuntime)
# add_subdirectory(builtins)

Am I missing something obvious?

I had a go and running them manually, and there are a couple of failures to
investigate:

error in __fixunsxfti(0X1P+0) = 0x00000000000000000000000000000000, expected
0x00000000000000000000000000000001
error in __fixxfti(0X1P+0) = 0x00000000000000000000000000000000, expected
0x00000000000000000000000000000001
error in __floattixf(0x00000000000000000000000000000001) = 0X0.000000000000EP-
1022, expected 0X1P+0
error in __floatuntixf(0x00000000000000000000000000000001) = 0X0.000000000000EP-
1022, expected 0X1P+0
Quuxplusone commented 8 years ago 
(In reply to comment #2)
> I double checked my results, and it seems like the builtin tests aren't
> getting run at all:
>
> # BlocksRuntime and builtins testsuites are not yet ported to lit.
> # add_subdirectory(BlocksRuntime)
> # add_subdirectory(builtins)
>
> Am I missing something obvious?

Likely not. Unfortunate, however, as I don't see why this would be difficult.
We should at least have a bug report tracking it.

>
> I had a go and running them manually, and there are a couple of failures to
> investigate:
>
> error in __fixunsxfti(0X1P+0) = 0x00000000000000000000000000000000, expected
> 0x00000000000000000000000000000001
> error in __fixxfti(0X1P+0) = 0x00000000000000000000000000000000, expected
> 0x00000000000000000000000000000001
> error in __floattixf(0x00000000000000000000000000000001) =
> 0X0.000000000000EP-1022, expected 0X1P+0
> error in __floatuntixf(0x00000000000000000000000000000001) =
> 0X0.000000000000EP-1022, expected 0X1P+0