search

Quuxplusone / LLVMBugzillaTest

0 stars 0 forks source link

[LSAN] [ARM] tls scanning for darwin LSan broke the ARMHF bots #32153

Open Quuxplusone opened 7 years ago

Quuxplusone commented 7 years ago
Bugzilla Link PR33181
Status NEW
Importance P enhancement
Reported by Renato Golin (rengolin@gmail.com)
Reported on 2017-05-26 10:31:48 -0700
Last modified on 2018-06-11 19:20:34 -0700
Version unspecified
Hardware PC Linux
CC adhemerval.zanella@linaro.org, alekseyshlgit@gmail.com, diana.picus@linaro.org, francisjricci@gmail.com, llvm-bugs@lists.llvm.org, mracek@apple.com, vitalybuka@google.com
Fixed by commit(s)
Attachments
Blocks
Blocked by
See also 
The commits:
http://llvm.org/viewvc/llvm-project?revision=303886&view=revision
http://llvm.org/viewvc/llvm-project?revision=303887&view=revision

broke some bots, but the fixup:
http://llvm.org/viewvc/llvm-project?revision=303906&view=revision

didn't bring the ARMv7 bot back to green:
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/7176

Since the failing test is new and meant for Darwin only, I tried to mark it
unsupported on ARM Linux in r304010.

If this is only meant to be tested in Darwin, then please, feel free to close
this bug. If not, we need to make sure why it's failing.
Quuxplusone commented 7 years ago

This is meant for all platforms. I assume that it's failing on ARM Linux because support for tls scanning hasn't been added yet? (If tls scanning is supposed to be supported on ARM Linux, then this test indicates a bug in that scanning).

As long as you disable only for ARM Linux, with a note that support hasn't been added for tls scanning, I'm fine with disabling it on that platform. However, you may also want to default use_tls to false on ARM Linux.

Quuxplusone commented 7 years ago 
(In reply to Francis Ricci from comment #1)
> This is meant for all platforms. I assume that it's failing on ARM Linux
> because support for tls scanning hasn't been added yet? (If tls scanning is
> supposed to be supported on ARM Linux, then this test indicates a bug in
> that scanning).
>
> As long as you disable only for ARM Linux, with a note that support hasn't
> been added for tls scanning, I'm fine with disabling it on that platform.
> However, you may also want to default use_tls to false on ARM Linux.

http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/lsan/TestCases/many_tls_keys.cc?r1=304010&r2=304009&pathrev=304010

@azanella, Any idea about TLS scanning support in ARMHF?
Quuxplusone commented 6 years ago

Is this fixed?