Open Quuxplusone opened 7 years ago
Quuxplusone
commented
7 years ago | Bugzilla Link | PR34484 |
| Status | NEW |
| Importance | P normal |
| Reported by | Sagi Ben (sagi@auroralabs.com) |
| Reported on | 2017-09-05 13:38:28 -0700 |
| Last modified on | 2018-10-25 20:11:57 -0700 |
| Version | unspecified |
| Hardware | PC Linux |
| CC | jbcoe@me.com, klimek@google.com, llvm-bugs@lists.llvm.org, richard-llvm@metafoo.co.uk |
| Fixed by commit(s) | |
| Attachments | |
| Blocks | |
| Blocked by | |
| See also |
Quuxplusone
commented
7 years ago backtrace for latest libclang :
#0 clang::TagType::getDecl() const () at /build/llvm-toolchain-snapshot-
6.0~svn312504/tools/clang/lib/AST/Type.cpp:2988
#1 0x00007ffff518f23d in (anonymous
namespace)::CXXNameMangler::mangleUnqualifiedName(clang::NamedDecl const*,
clang::DeclarationName, unsigned int, llvm::SmallVector<llvm::StringRef, 4u>
const*) [clone .constprop.749] () at /build/llvm-toolchain-snapshot-
6.0~svn312504/tools/clang/include/clang/AST/Type.h:3791
#2 0x00007ffff5190685 in (anonymous
namespace)::CXXNameMangler::mangleLocalName(clang::Decl const*,
llvm::SmallVector<llvm::StringRef, 4u> const*) ()
at /build/llvm-toolchain-snapshot-6.0~svn312504/tools/clang/lib/AST/ItaniumMangle.cpp:487
#3 0x00007ffff5190c1f in (anonymous
namespace)::CXXNameMangler::mangleNameWithAbiTags(clang::NamedDecl const*,
llvm::SmallVector<llvm::StringRef, 4u> const*) ()
at /build/llvm-toolchain-snapshot-6.0~svn312504/tools/clang/lib/AST/ItaniumMangle.cpp:866
#4 0x00007ffff518c7ef in (anonymous
namespace)::CXXNameMangler::mangleName(clang::NamedDecl const*) ()
at /build/llvm-toolchain-snapshot-6.0~svn312504/tools/clang/lib/AST/ItaniumMangle.cpp:822
#5 0x00007ffff5187ac1 in (anonymous
namespace)::ItaniumMangleContextImpl::mangleCXXName(clang::NamedDecl const*,
llvm::raw_ostream&) ()
at /build/llvm-toolchain-snapshot-6.0~svn312504/tools/clang/lib/AST/ItaniumMangle.cpp:4686
warning: Could not find DWO CU
CMakeFiles/clangIndex.dir/CodegenNameGenerator.cpp.dwo(0xf5a023084daf1c61)
referenced by CU at offset 0x1884 [in module /usr/lib/debug/.build-
id/71/6b13ccc5fd8b1fed075592557487fff0f3bd99.debug]
warning: (Internal error: pc 0x7ffff5331008 in read in psymtab, but not in
symtab.)
warning: (Internal error: pc 0x7ffff5330d70 in read in psymtab, but not in
symtab.)
warning: (Internal error: pc 0x7ffff5331008 in read in psymtab, but not in
symtab.)
warning: (Internal error: pc 0x7ffff5331008 in read in psymtab, but not in
symtab.)
warning: (Internal error: pc 0x7ffff5331008 in read in psymtab, but not in
symtab.)
#6 0x00007ffff5331009 in
clang::index::CodegenNameGenerator::getName[abi:cxx11](clang::Decl const*) ()
at /build/llvm-toolchain-snapshot-6.0~svn312504/tools/clang/lib/Index/CodegenNameGenerator.cpp:126
warning: (Internal error: pc 0x7ffff5331008 in read in psymtab, but not in
symtab.)
warning: Could not find DWO CU
CMakeFiles/libclang.dir/CIndex.cpp.dwo(0xa704430e2abfdcd4) referenced by CU at
offset 0x68 [in module /usr/lib/debug/.build-
id/71/6b13ccc5fd8b1fed075592557487fff0f3bd99.debug]
#7 0x00007ffff506cfaa in clang_Cursor_getMangling () at /build/llvm-toolchain-
snapshot-6.0~svn312504/tools/clang/tools/libclang/CIndex.cpp:4625
#8 0x00007ffff66f8e20 in ffi_call_unix64 () from /usr/lib/python3.5/lib-
dynload/_ctypes.cpython-35m-x86_64-linux-gnu.so
#9 0x00007ffff66f888b in ffi_call () from /usr/lib/python3.5/lib-
dynload/_ctypes.cpython-35m-x86_64-linux-gnu.so
#10 0x00007ffff66f301a in _call_function_pointer (argcount=1,
resmem=0x7fffffffca10, restype=<optimized out>, atypes=<optimized out>,
avalues=0x7fffffffc9f0,
pProc=0x7ffff506cee0 <clang_Cursor_getMangling>, flags=4353) at /build/python3.5-9imW1d/python3.5-3.5.2/Modules/_ctypes/callproc.c:811
#11 _ctypes_callproc (pProc=0x7ffff506cee0 <clang_Cursor_getMangling>,
argtuple=<optimized out>, flags=4353,
argtypes=(<built-in method from_param of _ctypes.PyCStructType object at remote 0xb97388>,), restype=<_ctypes.PyCStructType at remote 0xb874c8>, checker=0x0)
at /build/python3.5-9imW1d/python3.5-3.5.2/Modules/_ctypes/callproc.c:1149
#12 0x00007ffff66e6fcb in PyCFuncPtr_call.lto_priv.89
(self=self@entry=0x7ffff66b0cc8, inargs=<optimized out>, kwds=<optimized out>)
at /build/python3.5-9imW1d/python3.5-3.5.2/Modules/_ctypes/_ctypes.c:3856
#13 0x00000000005b7167 in PyObject_Call () at ../Objects/abstract.c:2165
#14 0x0000000000528d06 in do_call (nk=<optimized out>, na=<optimized out>,
pp_stack=0x7fffffffccf0, func=<optimized out>) at ../Python/ceval.c:4936
#15 call_function (oparg=<optimized out>, pp_stack=0x7fffffffccf0) at
../Python/ceval.c:4732
#16 PyEval_EvalFrameEx () at ../Python/ceval.c:3236
#17 0x000000000052e12b in _PyEval_EvalCodeWithName (qualname=0x0, name=0x0,
closure=0x0, kwdefs=0x0, defcount=0, defs=0x0, kwcount=0, kws=<optimized out>,
argcount=<optimized out>, args=<optimized out>, locals=<optimized out>, globals=<optimized out>, _co=<code at remote 0x7ffff6968270>) at ../Python/ceval.c:4018
#18 PyEval_EvalCodeEx () at ../Python/ceval.c:4039
#19 0x00000000004ebcc3 in function_call.lto_priv () at
../Objects/funcobject.c:627
#20 0x00000000005b7167 in PyObject_Call () at ../Objects/abstract.c:2165
#21 0x00000000004ee1c0 in property_descr_get.lto_priv () at
../Objects/descrobject.c:1398
#22 0x00000000005763bd in _PyObject_GenericGetAttrWithDict () at
../Objects/object.c:1059
#23 0x000000000052424b in PyEval_EvalFrameEx () at ../Python/ceval.c:2743
#24 0x0000000000528814 in fast_function (nk=<optimized out>, na=<optimized
out>, n=<optimized out>, pp_stack=0x7fffffffd160, func=<optimized out>) at
../Python/ceval.c:4803
#25 call_function (oparg=<optimized out>, pp_stack=0x7fffffffd160) at
../Python/ceval.c:4730
---Type <return> to continue, or q <return> to quit---
#26 PyEval_EvalFrameEx () at ../Python/ceval.c:3236
#27 0x0000000000528814 in fast_function (nk=<optimized out>, na=<optimized
out>, n=<optimized out>, pp_stack=0x7fffffffd290, func=<optimized out>) at
../Python/ceval.c:4803
#28 call_function (oparg=<optimized out>, pp_stack=0x7fffffffd290) at
../Python/ceval.c:4730
#29 PyEval_EvalFrameEx () at ../Python/ceval.c:3236
#30 0x0000000000528814 in fast_function (nk=<optimized out>, na=<optimized
out>, n=<optimized out>, pp_stack=0x7fffffffd3c0, func=<optimized out>) at
../Python/ceval.c:4803
#31 call_function (oparg=<optimized out>, pp_stack=0x7fffffffd3c0) at
../Python/ceval.c:4730
#32 PyEval_EvalFrameEx () at ../Python/ceval.c:3236
#33 0x0000000000528814 in fast_function (nk=<optimized out>, na=<optimized
out>, n=<optimized out>, pp_stack=0x7fffffffd4f0, func=<optimized out>) at
../Python/ceval.c:4803
#34 call_function (oparg=<optimized out>, pp_stack=0x7fffffffd4f0) at
../Python/ceval.c:4730
#35 PyEval_EvalFrameEx () at ../Python/ceval.c:3236
#36 0x0000000000528814 in fast_function (nk=<optimized out>, na=<optimized
out>, n=<optimized out>, pp_stack=0x7fffffffd620, func=<optimized out>) at
../Python/ceval.c:4803
#37 call_function (oparg=<optimized out>, pp_stack=0x7fffffffd620) at
../Python/ceval.c:4730
#38 PyEval_EvalFrameEx () at ../Python/ceval.c:3236
#39 0x0000000000528814 in fast_function (nk=<optimized out>, na=<optimized
out>, n=<optimized out>, pp_stack=0x7fffffffd750, func=<optimized out>) at
../Python/ceval.c:4803
#40 call_function (oparg=<optimized out>, pp_stack=0x7fffffffd750) at
../Python/ceval.c:4730
#41 PyEval_EvalFrameEx () at ../Python/ceval.c:3236
#42 0x000000000052d2e3 in _PyEval_EvalCodeWithName () at ../Python/ceval.c:4018
#43 0x000000000052dfdf in PyEval_EvalCodeEx () at ../Python/ceval.c:4039
#44 PyEval_EvalCode (co=<optimized out>, globals=<optimized out>,
locals=<optimized out>) at ../Python/ceval.c:777
#45 0x00000000005fd2c2 in run_mod () at ../Python/pythonrun.c:976
#46 0x00000000005ff76a in PyRun_FileExFlags () at ../Python/pythonrun.c:929
#47 0x00000000005ff95c in PyRun_SimpleFileExFlags () at
../Python/pythonrun.c:396
#48 0x000000000063e7d6 in run_file (p_cf=0x7fffffffd9c0, filename=0xa732a0
L"./traverse.py", fp=0xb6bc30) at ../Modules/main.c:318
#49 Py_Main () at ../Modules/main.c:768
#50 0x00000000004cfe41 in main () at ../Programs/python.c:65
#51 0x00007ffff7810830 in __libc_start_main (main=0x4cfd60 <main>, argc=3,
argv=0x7fffffffdbd8, init=<optimized out>, fini=<optimized out>,
rtld_fini=<optimized out>,
stack_end=0x7fffffffdbc8) at ../csu/libc-start.c:291
#52 0x00000000005d5f29 in _start ()The call to node.mangled_name is causing a crash, not sure if that might give you an interim fix.
I'll dig into why this goes wrong.
Quuxplusone
commented
7 years ago Hi,
Thanks !!
I verified that removing it from the print statement hide the crash,
but should it crash with seg fault of should it throw an exception.
Sagi.The issue seems to be in ItaniumMangle.cpp and can be triggered on macOS by
asking for mangled names from a C++ (not C) TU containing a struct with a
void(*)(void*) function pointer member.
I'm not familiar with this part of clang but have a very simple patch that
might provide a useful starting point for further investigation.
Simple test (and crude fix) submitted to Phabricator as:
https://reviews.llvm.org/D37639I applied the patch on the latest clang source code.
I get assertion failed error :
/home/sagi/trees/community/clang/lib/AST/ItaniumMangle.cpp:1337: void
(anonymous namespace)::CXXNameMangler::mangleUnqualifiedName(const
clang::NamedDecl *, clang::DeclarationName, unsigned int, const (anonymous
namespace)::CXXNameMangler::AbiTagList *): Assertion `RD-
>isAnonymousStructOrUnion() && "Expected anonymous struct or union!"' failed.@Sagi Ben Thanks for your comment.
I'm afraid the patch is intended to be a starting point for investigation, nothing more. I doubt that it would be an adequate fix without further work by someone more familiar with the Itanium ABI code.
Quuxplusone
commented
6 years ago I've submitted another review request to Phabricator :
https://reviews.llvm.org/D39639