search

Quuxplusone / LLVMBugzillaTest

0 stars 0 forks source link

Embed command line options to generated binaries #35612

Open Quuxplusone opened 6 years ago

Quuxplusone commented 6 years ago
Bugzilla Link PR36639
Status NEW
Importance P enhancement
Reported by Rui Ueyama (ruiu@google.com)
Reported on 2018-03-07 15:46:04 -0800
Last modified on 2018-03-08 02:11:49 -0800
Version unspecified
Hardware All All
CC dimitry@andric.com, emaste@freebsd.org, llvm-bugs@lists.llvm.org
Fixed by commit(s)
Attachments
Blocks
Blocked by
See also

I wonder if it is useful to embed more information to lld-generated binaries. Currently we put lld version number to a .comment section, and I found that very useful.

We may want to embed the entire command line to a .comment section as well, so that we can trace how an executable or DSO was created.

Quuxplusone commented 6 years ago

I think this is a nice feature to have, but please also consider that such command lines might leak information about the build system(s), which may be sensitive. This could also make it more difficult to get reproducible builds.

So if it is added, I would suggest not turning it on by default, at least.