Quuxplusone / LLVMBugzillaTest

0 stars 0 forks source link

libc++abi fails to compile on arm when build against libgcc's arm unwind with: cxa_personality.cpp:594:30: error: ‘_URC_FATAL_PHASE2_ERROR’ was not declared in this scope #38222

Open Quuxplusone opened 6 years ago

Quuxplusone commented 6 years ago
Bugzilla Link PR39249
Status NEW
Importance P enhancement
Reported by Steffen Kuhn (herrtimson@yahoo.de)
Reported on 2018-10-10 23:59:52 -0700
Last modified on 2018-10-14 11:16:42 -0700
Version 7.0
Hardware PC Linux
CC llvm-bugs@lists.llvm.org, mclow.lists@gmail.com, mgorny@gentoo.org
Fixed by commit(s)
Attachments 0001-in-addition-to-pr35945.patch (1256 bytes, text/plain)
libcxxabi-7.0.0-gcc.gz (4065 bytes, application/gzip)
Blocks
Blocked by
See also
Created attachment 20987
patch to fix this bug

This is follow-up of https://bugs.llvm.org/show_bug.cgi?id=35945, which reports
that libc++ doesn't build for the Raspberry PI.

Errors related to char[8] are fixed now, but there are some missing values from
_Unwind_Reason_Code enum and wrong behavior of  _US_FORCE_UNWIND

I isolated the added lines (with permission) from this fedora patch:
https://src.fedoraproject.org/rpms/v8/blob/master/f/v8-6.7.17-fix-gcc-unwind-header.patch

https://reviews.llvm.org/D53127

please assign mgorny@gentoo.org, he agreed to help out if there are unforeseen
problems with this patch.
Quuxplusone commented 6 years ago

Attached 0001-in-addition-to-pr35945.patch (1256 bytes, text/plain): patch to fix this bug

Quuxplusone commented 6 years ago

This fix and the fix for https://bugs.llvm.org/show_bug.cgi?id=35945 should be included into upcoming 7.0.1 and 6.0.2 (if there will be one)

Quuxplusone commented 6 years ago

I've said this on the review, but I want to say it here too - this doesn't have anything to do with being built with gcc.

this has to do with using gcc's ARM unwind library.

Quuxplusone commented 6 years ago

I tried to be more precise with the title, okay for you?

Or do you think that this is actually a bug within gcc's implementation of unwind on arm?

Quuxplusone commented 6 years ago

Attached libcxxabi-7.0.0-gcc.gz (4065 bytes, application/gzip): compressed build log