Update patch submission guidelines

[Quuxplusone]

Bugzilla Link	PR39399
Status	NEW
Importance	P enhancement
Reported by	Samuel Thibault (samuel.thibault@ens-lyon.org)
Reported on	2018-10-23 01:10:50 -0700
Last modified on	2019-01-27 11:03:26 -0800
Version	unspecified
Hardware	PC Linux
CC	dblaikie@gmail.com, llvm-bugs@lists.llvm.org, rnk@google.com
Fixed by commit(s)
Attachments
Blocks
Blocked by
See also

Hello,

http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch

says "Once your patch is ready, submit it by emailing it to the appropriate project’s commit mailing list". But from the traffic on llvm-commit, it seems that phabricator is largely preferred nowadays, and a patch sent to the mailing list will get lost.

That page should thus probably rather point at http://llvm.org/docs/Phabricator.html nowadays.

[Quuxplusone]

Not sure - I mean, maybe a bit more of a nod to phab, but still the review system of record is the commits mailing lists & Phab is one way to send mail there in a more structured form. (but yeah, some reviewers prefer Phab, so can be good to use it to make things as easy as possible for the reviewer & more likely to get code reviewed - but maybe that should be grouped under other tips like "keep patches small/incremental", etc)

[Quuxplusone]

I think the real important guidance is to directly cc someone who might care about the patch because it's in the area they work in. The reality is that LLVM is a much higher volume project than it used to be, so nobody just "reads" llvm-commits for patches.

[Quuxplusone]

(In reply to Reid Kleckner from comment #2)
> I think the real important guidance is to directly cc someone who might care
> about the patch because it's in the area they work in. The reality is that
> LLVM is a much higher volume project than it used to be, so nobody just
> "reads" llvm-commits for patches.

Hey now, some of us do & in theory review-after-commit does still mean people
should be reading other people's submitted patches, etc. But, yes, we could do
with more ownership understanding (explicitly documented, and/or people signing
up for Phab notifications for changes in certain areas, etc).