search

Quuxplusone / LLVMBugzillaTest

0 stars 0 forks source link

Change llvm call once check for PowerPC(ppc64le) #38884

Open Quuxplusone opened 5 years ago

Quuxplusone commented 5 years ago
Bugzilla Link PR39912
Status NEW
Importance P release blocker
Reported by Sarvesh Tamba (sarvesh.tamba@ibm.com)
Reported on 2018-12-07 03:39:03 -0800
Last modified on 2019-01-07 19:55:05 -0800
Version trunk
Hardware PC other
CC hfinkel@anl.gov, llvm-bugs@lists.llvm.org, nemanja.i.ibm@gmail.com, powerllvm@ca.ibm.com
Fixed by commit(s)
Attachments llvm_Threading.patch (794 bytes, text/plain)
Blocks
Blocked by
See also 
Created attachment 21200
Patch to fix call_once errors on PowerPC64le

This change is required to resolve the call_once related errors seen while
building the Swift toolchain on PowerPC64LE.
Quuxplusone commented 5 years ago

Attached llvm_Threading.patch (794 bytes, text/plain): Patch to fix call_once errors on PowerPC64le

Quuxplusone commented 5 years ago 
Can you please post this on Phabricator according to instructions at:
https://llvm.org/docs/Contributing.html#how-to-submit-a-patch

and describe why the existing macro checks are inadequate (i.e. compiler X does
not define __ppc__ on ppc64le, or something along those lines).
Quuxplusone commented 5 years ago 
Hi Nemanja Ivanovic,

I have posted this patch on LLVM's Phabricator as per your suggestion.
Following is the link for patch review:-
https://reviews.llvm.org/D55503
Please let me know if anything else is required.
Quuxplusone commented 5 years ago 
Hi Nemanja Ivanovic,
Can you please review this on LLVM's
Phabricator(https://reviews.llvm.org/D55503)? This change is resolving a
blocker while building swift toolchain on PowerPC64LE and is a bit urgent.
Since this is a small change, can you please take this up? Thanks!
Quuxplusone commented 5 years ago 
@nemanjai Created a new diff - https://reviews.llvm.org/D56382
Please review.