search

Quuxplusone / LLVMBugzillaTest

0 stars 0 forks source link

[AMDGPU] Monster Hunter World renders incorrectly when SILoadStoreOptimizer is enabled #39102

Closed Quuxplusone closed 5 years ago

Quuxplusone commented 5 years ago
Bugzilla Link PR40130
Status RESOLVED FIXED
Importance P release blocker
Reported by Samuel Pitoiset (samuel.pitoiset@gmail.com)
Reported on 2018-12-21 08:35:37 -0800
Last modified on 2019-05-17 02:36:42 -0700
Version trunk
Hardware PC Linux
CC htmldeveloper@gmail.com, llvm-bugs@lists.llvm.org, samuel.pitoiset@gmail.com, tpr.ll@botech.co.uk
Fixed by commit(s)
Attachments ir.ll (58228 bytes, text/plain)
good.jpg (910852 bytes, image/jpeg)
bad.jpg (824635 bytes, image/jpeg)
possible_fix (740 bytes, text/plain)
Blocks
Blocked by
See also 
Created attachment 21262
LLVM IR

Hi,

Disabling SILoadStoreOptimizer for the attached IR fixes the problem. The IR
right after that pass looks correct to me. This probably trigger a problem
later in the process. Note that LLVM 6 doesn't expose the issue.

[1] https://github.com/doitsujin/dxvk/issues/701
Quuxplusone commented 5 years ago

Attached ir.ll (58228 bytes, text/plain): LLVM IR

Quuxplusone commented 5 years ago

Attached good.jpg (910852 bytes, image/jpeg): good

Quuxplusone commented 5 years ago

Attached bad.jpg (824635 bytes, image/jpeg): bad

Quuxplusone commented 5 years ago 
Samuel asked me to take a look at this.

The demo ll uses the removed intrinsic llvm.SI.load.const.*, so I had to go
back to rL351584, just before it was removed.
Quuxplusone commented 5 years ago

Sorry, I don't see anything obviously wrong when comparing the output with SILoadStoreOptimizer against the output without SILoadStoreOptimizer. I do not have any way to debug it further.

Quuxplusone commented 5 years ago

Thanks Tim, I will see if I can do a better evaluation of the problem.

Quuxplusone commented 5 years ago

Attached possible_fix (740 bytes, text/plain): possible fix

Quuxplusone commented 5 years ago

Fixed with r361008.