Open Quuxplusone opened 5 years ago
Bugzilla Link | PR42761 |
Status | NEW |
Importance | P enhancement |
Reported by | Nick Terrell (terrelln@fb.com) |
Reported on | 2019-07-25 13:02:49 -0700 |
Last modified on | 2019-07-28 09:12:46 -0700 |
Version | 9.0 |
Hardware | PC All |
CC | llvm-bugs@lists.llvm.org, mclow.lists@gmail.com, terrelln@fb.com, z.zoelec2@gmail.com |
Fixed by commit(s) | |
Attachments | |
Blocks | |
Blocked by | |
See also |
Using bucket would be more performant, but it fails in cases like the following:
unordered_set<int> a = { 1, 1, 2 };
unordered_set<int> b = { 1, 2, 2 };
assert(eqSet(a, b) != true);
(In reply to Zoe Carver from comment #1)
> Using bucket would be more performant, but it fails in cases like the
> following:
>
> unordered_set<int> a = { 1, 1, 2 };
> unordered_set<int> b = { 1, 2, 2 };
> assert(eqSet(a, b) != true);
These two sets seem equal to me and both algorithms report equal, do you mean
unordered_multiset?
You're right that this algorithm won't work with multiset. I only propose that
we change unordered_{map,set}::operator==.
Yes, you are right. My bad. Disregard my comment.