search

Quuxplusone / LLVMBugzillaTest

0 stars 0 forks source link

Define a consistent scheme for SPIR-V assembly #43797

Open Quuxplusone opened 4 years ago

Quuxplusone commented 4 years ago
Bugzilla Link PR44827
Status NEW
Importance P enhancement
Reported by Lei Zhang (antiagainst@google.com)
Reported on 2020-02-07 07:29:31 -0800
Last modified on 2020-12-14 15:16:16 -0800
Version unspecified
Hardware PC All
CC joker.eph@gmail.com, ravishankarm@google.com
Fixed by commit(s)
Attachments
Blocks
Blocked by
See also

Right now the op custom assembly is a bit arbitrary; we use () and , and other keywords without a consistent scheme. For example, spv.globalVariable wraps initializer SSA value with intializer(...) but for other ops SSA values are typically just separated with comma. Another example is that spv.Load/spv.Store wraps memory operands like "Volatile" with [...] but for other ops we typically don't. We should define a consistent scheme.

Quuxplusone commented 3 years ago

What is the status on this?

Quuxplusone commented 3 years ago

I think this is being worked on right now. This patch is https://reviews.llvm.org/D92919 making progress on this.