search

Quuxplusone / LLVMBugzillaTest

0 stars 0 forks source link

hurd.c test fails on a two-stage ThinLTO build #44031

Closed Quuxplusone closed 4 years ago

Quuxplusone commented 4 years ago
Bugzilla Link PR45061
Status RESOLVED FIXED
Importance P enhancement
Reported by Alexandre Ganea (alex_toresh@yahoo.fr)
Reported on 2020-02-28 11:08:07 -0800
Last modified on 2020-04-29 15:29:05 -0700
Version 10.0
Hardware PC Windows NT
CC hans@chromium.org, llvm-bugs@lists.llvm.org, neeilans@live.com, richard-llvm@metafoo.co.uk, tstellar@redhat.com
Fixed by commit(s) rG7e77cf473ac9d8f8b65db017d660892f1c8f4b75, rG9cf9cf2a398
Attachments hurd.patch (6471 bytes, text/plain)
Blocks PR45309
Blocked by
See also

When running a two-stage ThinLTO build on Windows, where the second stage uses these commands:

> set OPT_SKYLAKE=/GS- /D_ITERATOR_DEBUG_LEVEL=0 -Xclang -O3 -Xclang -fwhole-program-vtables -fstrict-aliasing -march=skylake-avx512
> cmake "-DLLVM_LIT_ARGS=-sv -j 36" -G"Ninja" %ROOT%/llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_OPTIMIZED_TABLEGEN=true -DLLVM_ENABLE_LIBXML2=OFF -DLLVM_USE_CRT_RELEASE=MT -DCMAKE_C_COMPILER="%STAGE1%/bin/clang-cl.exe" -DCMAKE_CXX_COMPILER="%STAGE1%/bin/clang-cl.exe" -DCMAKE_LINKER="%STAGE1%/bin/lld-link.exe" -DLLVM_ENABLE_LLD=ON -DLLVM_ENABLE_PDB=ON -DLLVM_ENABLE_PROJECTS="llvm;clang;lld" -DCMAKE_CXX_FLAGS="%OPT_SKYLAKE%" -DCMAKE_C_FLAGS="%OPT_SKYLAKE%" -DLLVM_ENABLE_LTO=THIN -DCLANG_TABLEGEN="%STAGE1%/bin/clang-tblgen.exe" -DLLVM_TABLEGEN="%STAGE1%/bin/llvm-tblgen.exe" 
> ninja check-all

The test hurd.c fails. I will post a fix shortly.

Occurs in release/10.x.

Quuxplusone commented 4 years ago

Please see: https://reviews.llvm.org/D75373

Quuxplusone commented 4 years ago

I don't think we can hold 10.0.0 for this, and I'm not sure whether it's a regression from 9.

Seems like a good fix for 10.0.1 though.

Quuxplusone commented 4 years ago

Fixed in https://github.com/llvm/llvm-project/commit/7e77cf473ac9d8f8b65db017d660892f1c8f4b75

Hans: It's fine for 10.0.1, thanks!

Quuxplusone commented 4 years ago

This patch does not cherry-pick cleanly. Would someone be able to either cherry-pick and push to a branch on their personal GitHub fork or attach a patch to this bug?

Quuxplusone commented 4 years ago

I can do it.

Quuxplusone commented 4 years ago

Attached hurd.patch (6471 bytes, text/plain): Rebased patch on release/10.x

Quuxplusone commented 4 years ago

Kristina, any objections to merging this?

https://github.com/tstellar/llvm-project/pull/96/files

Quuxplusone commented 4 years ago

No objections, looks good!

Quuxplusone commented 4 years ago

Merged: 9cf9cf2a398