fix: installable PWA - Githubissues

userquin commented 9 months ago

This PR includes:

update typescript to v5.3.3
adds TODO.md file with pending todos
updates readme file to include changes in manifest.json, service-worker.ts and tsconfig.json (with diff format)
adds initial support for prompt strategy: just the mode in setupPwa
removes ./* from pnpm workspace
don't inject manifest icons when present
refactor manifest module to include id, scope and icons when required in the web manifest (included also a warning when color_theme missing)
refactor assets plugin to handle configuration changes properly (custom pwa assets configuration file)
added .npmrc with shell-emulator=true to test custom pwa assets configuration file changes: added the file and script (dev.custom) to run the test

cloudflare-workers-and-pages[bot] commented 9 months ago

Deploying with Cloudflare Pages

Latest commit:	`6551a80`
Status:	✅ Deploy successful!
Preview URL:	https://362081b7.pwa-a3b.pages.dev
Branch Preview URL:	https://userquin-fix-installable-pwa.pwa-a3b.pages.dev

userquin commented 9 months ago

It seems there are some images in the app that requires gh auth (2fa in my case), testing PR preview on my Android device via usb cable:

Aslemammad commented 9 months ago

Still not installable on my phone, it just creates a shortcut, it says it installs it but it does not!

userquin commented 9 months ago

Now the web manifest will be always served by the generator, we need to include the id and the scope, and the icons when required.

I'm going to add a warning when the web manifest doesn't have theme_color.