search

QwikDev / astro

Qwik + Astro integration
216 stars 13 forks source link

make q:base configurable #37

Closed RikJurriaans closed 11 months ago

RikJurriaans commented 11 months ago

Hi,

We've started to use qwik in one of our apps but we need to be able to configure the base path.

If theres a better way for us to do this then I'm happy to change it.

Thanks.

thejackshelton commented 11 months ago

Happy to merge it once those changes are made! Appreciate the help 😄

thejackshelton commented 11 months ago

After the suggested change above:

process.env.Q_BASE = normalizedPath

right under 

let normalizedPath = normalize(outputPath);

inside of index.ts

I can't add anything in your PR, and if I can, I don't know how 😆

I get

 ! [remote rejected] HEAD -> pr/RikJurriaans/37 (permission denied)
error: failed to push some refs to 'https://github.com/rikjurriaans/astro'
thejackshelton commented 11 months ago

Looks good! Merging.