search

QwikDev / astro

Qwik + Astro integration
216 stars 13 forks source link

Fix #68: Make moveArtifacts merge directories #69

Closed FloezeTv closed 8 months ago

FloezeTv commented 8 months ago

See #68.

I have added a dependency on fs-move. As that is implemented in JS, I added type definitions to src/custom_types.

Regarding the behavior: moveArtifacts now merges the directories when moving. If a file already exists in dist, it is not being overwritten. This matches the behavior I have noticed on plain astro where when a file exists in public that would be replaced by the astro-generated page (e.g., public/some_page/index.html and src/pages/some_page.astro both exist; only the generated html from src/pages/some_page.astro shows up in the final build). I don't know if there are any other cases where a file in dist should be overwritten - this should only happen if astro generated a file at the same path as qwik does.

thejackshelton commented 8 months ago

Awesome job! Merging and releasing 0.5.9