search

QwikDev / qwik-image

Qwik Image Component
MIT License
53 stars 5 forks source link

Changing props after first render does not update the component #2

Closed DustinJSilk closed 1 year ago

DustinJSilk commented 1 year ago

It's seems reactivity is not working. The image component renders correctly on the first render, however, if you need to change any of the input props like it's layout or src after creating the component, it doesn't update.

This looks like it is because the logic for generating the src, sizes, and layouts is coded at the component level rather than in a reactive task$ or computed$ function.

gioboa commented 1 year ago

Thanks for the report. I saw your PR and I think you've done a great improvement Are you building a real application with it? Please share a link of your app if you can.

DustinJSilk commented 1 year ago

Thanks for you amazing work here! Yes i am building a real application, i have a new version going live to deprecate a large part of the old angular app which goes live this week, i'll share a link once its up

gioboa commented 1 year ago

I released the new version qwik-image-0.0.7 with this feature

DustinJSilk commented 1 year ago

Thanks @gioboa ! This is now live on my new search page https://staze.com/