QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.83k stars 1.31k forks source link

[🐞] custom slot props not working on production #2671

Closed O-Hooman closed 1 year ago

O-Hooman commented 1 year ago

Which component is affected?

Qwik Runtime

Describe the bug

When I tried to make a custom slot by passing it as props it's works on dev but when run preview it doesn't work

Run preview/build:

Screenshot 2023-01-19 at 2 18 49 PM

Run dev:

Screenshot 2023-01-19 at 2 18 20 PM

Notes: it was working before I upgrade to version 0.16.2 (before the upgrade I'm using 0.12.1)

Reproduction

https://stackblitz.com/edit/qwik-starter-a4rsbf

Steps to reproduce

npm run preview / npm run build

System Info

System:
    OS: macOS 13.0
    CPU: (8) arm64 Apple M1
    Memory: 94.38 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.17.0/bin/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm
  Browsers:
    Chrome: 109.0.5414.87
    Safari: 16.1
  npmPackages:
    @builder.io/qwik: 0.16.2 => 0.16.2 
    @builder.io/qwik-city: 0.0.128 => 0.0.128 
    undici: 5.14.0 => 5.14.0 
    vite: 4.0.4 => 4.0.4

Additional Information

No response

stackblitz[bot] commented 1 year ago

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

manucorporat commented 1 year ago

Looking!

O-Hooman commented 1 year ago

Looking!

Thanks! Let me know if you need more example for reproduction, the current one is just simple one

manucorporat commented 1 year ago

Should be working already!