QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.89k stars 1.31k forks source link

[🐞] npm create qwik@latest delivers broken project-template #2971

Closed GregOnNet closed 1 year ago

GregOnNet commented 1 year ago

Which component is affected?

Qwik Runtime

Describe the bug

npn start

The following error is thrown.

  VITE v4.1.1  ready in 498 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h to show help
4:19:40 PM [vite] Internal server error: The <table> element requires that its direct children to be '<tbody>' or '<thead>', instead, '<tr>' was rendered.
  File: /home/gregonnet/workbench/scratch/qwik-app/src/routes/index.tsx:34:9
  32 |
  33 |        <table class="commands">
  34 |          <tr>
     |           ^
  35 |            <td>
  36 |              <code>npm run dev</code>
      at routes_component_crp5PYqmBUM (/home/gregonnet/workbench/scratch/qwik-app/src/routes/index.tsx:34:8)
      at async Promise.all (index 0)
      at async Promise.all (index 1)
      at async Promise.all (index 0)

Resolution

npm run build

The followin error is thrown.

❯ npm run build                                                                                                                                              

> build                                                                                                                                                      
> qwik build                                                                                                                                                 

npm run build.types                                                                                                                                          
npm run build.client                                                                                                                                         
npm run lint                                                                                                                                                 

> build.client                                                                                                                                               
> vite build                                                                                                                                                 

vite v4.1.1 building for production...                                                                                                                       
✓ 62 modules transformed.                                                                                                                                    
Could not resolve "./routes/docs.css?used&inline" from "src/s_pzsgc9jdcli.js"                                                                                
file: /home/gregonnet/workbench/scratch/qwik-app/src/s_pzsgc9jdcli.js                                                                                        
error during build:                                                                                                                                          
RollupError: Could not resolve "./routes/docs.css?used&inline" from "src/s_pzsgc9jdcli.js"                                                                   
    at error (file:///home/gregonnet/workbench/scratch/qwik-app/node_modules/.pnpm/rollup@3.15.0/node_modules/rollup/dist/es/shared/rollup.js:2091:30)       
    at ModuleLoader.handleInvalidResolvedId (file:///home/gregonnet/workbench/scratch/qwik-app/node_modules/.pnpm/rollup@3.15.0/node_modules/rollup/dist/es/s
hared/rollup.js:23333:24)                                                                                                                                    
    at file:///home/gregonnet/workbench/scratch/qwik-app/node_modules/.pnpm/rollup@3.15.0/node_modules/rollup/dist/es/shared/rollup.js:23295:26              

Resolution

import { component$, Slot, useStyles$ } from '@builder.io/qwik';
import type { DocumentHead } from '@builder.io/qwik-city';
import Menu from '~/components/menu/menu';
import OnThisPage from '~/components/on-this-page/on-this-page';

// TODO: Write ./ instead of ../
import styles from '../docs.css?inline';

export default component$(() => {
  useStyles$(styles);

  return (
    <div class="docs">
      <Menu />
      <article>
        <Slot />
      </article>
      <OnThisPage />
    </div>
  );
});

export const head: DocumentHead = ({ head }) => {
  return {
    title: `${head.title} - Documentation`
  };
};

Reproduction

https://stackblitz.com/edit/qwik-starter?file=NOT_APPLICABLE

Steps to reproduce

Reproduction URL not applicable here.

npm craete qwik@latest
# Choose Name
# Choose Documentation Site
# Install Dependencies
cd ./qwik-app
npm starrt

System Info

System:
    OS: Linux 5.15 Ubuntu 20.04.5 LTS (Focal Fossa)
    CPU: (20) x64 Intel(R) Core(TM) i9-10850K CPU @ 3.60GHz
    Memory: 9.16 GB / 15.57 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 18.14.0 - ~/.nvm/versions/node/v18.14.0/bin/node
    Yarn: 1.22.19 - /mnt/c/Users/gregor.woiwode/AppData/Roaming/npm/yarn
    npm: 9.3.1 - ~/.nvm/versions/node/v18.14.0/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
  npmPackages:
    @builder.io/qwik: 0.17.5 => 0.17.5
    @builder.io/qwik-city: 0.1.0 => 0.1.0
    undici: 5.18.0 => 5.18.0
    vite: 4.1.1 => 4.1.1

Additional Information

I am willing to send a Pull-Request

stackblitz[bot] commented 1 year ago

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

manucorporat commented 1 year ago

we just add the tbody! should be fixed in new starters!

GregOnNet commented 1 year ago

Thanks