QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.83k stars 1.31k forks source link

[🐞] q:key containing double quotes breaks on server side render #3091

Closed christinatka closed 1 year ago

christinatka commented 1 year ago

Which component is affected?

Qwik Runtime

Describe the bug

Using strings that contain double quotes as the key for elements breaks on server-side render. Expect a string with double quotes to still work as a valid q:key.

Reproduction

https://stackblitz.com/edit/qwik-starter-s6bdue?file=src%2Froutes%2Findex.tsx

Steps to reproduce

No response

System Info

System:
    OS: macOS 13.0.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 57.91 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
    npm: 8.5.0 - ~/.nvm/versions/node/v16.14.2/bin/npm
  Browsers:
    Chrome: 110.0.5481.100
    Firefox: 110.0
    Safari: 16.1
  npmPackages:
    @builder.io/qwik: 0.19.0 => 0.19.0 
    @builder.io/qwik-city: 0.3.0 => 0.3.0 
    undici: ^5.20.0 => 5.20.0 
    vite: 4.1.3 => 4.1.3

Additional Information

Have a PR incoming shortly

stackblitz[bot] commented 1 year ago

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.