[🐞] VSC and Webstorm emmets autocompletes for react

LazyClicks commented 1 year ago

Which component is affected?

Qwik Runtime

Describe the bug

an example is i would do div.name what i would expect is a <div class="name"></div> but what comes up is <div className="name"></div> the react way i tried both webstorm and vsc and both have this issue

Reproduction

https://github.com/LazyClicks/first-qwik-project

Steps to reproduce

No response

System Info

System:
    OS: Windows 10 10.0.22621
    CPU: (4) x64 AMD Ryzen 3 3200G with Radeon Vega Graphics    
    Memory: 5.19 GB / 15.91 GB
  Binaries:
    Node: 18.15.0 - C:\Program Files\nodejs\node.EXE
    npm: 9.5.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.1702.0), Chromium (113.0.1774.42)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @builder.io/qwik: ^1.1.2 => 1.1.2
    @builder.io/qwik-city: ^1.1.2 => 1.1.2
    undici: 5.22.0 => 5.22.0
    vite: 4.3.5 => 4.3.5

Additional Information

No response

manucorporat commented 1 year ago

no idea how we can fix this, is there a setting in vscode?

LazyClicks commented 1 year ago

sorry didn't see a noti for a reply i think vsc is treating it like react since it's .tsx?

LazyClicks commented 1 year ago

problem is with emmet not supporting qwik, here's an issue in it https://github.com/emmetio/emmet/issues/718

gioboa commented 12 months ago

@LazyClicks is it still an issue?

LazyClicks commented 12 months ago

@LazyClicks is it still an issue?

It sometimes occurs now, which is very weird Sometimes it's correct sometimes it's react className

gioboa commented 12 months ago

Can we do something to solve it or is it something out of our control?

LazyClicks commented 11 months ago

Can we do something to solve it or is it something out of our control?

apparently u can edit the configs for emmet to fix it, havent tried it yet here

gioboa commented 11 months ago

Would you like to open a PR for that? Thanks in advance

QwikDev / qwik