QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.45k stars 1.26k forks source link

[🐞] Qwik Packages entry point must be exactly `index.qwik` or build breaks #4952

Open samijaber opened 10 months ago

samijaber commented 10 months ago

Which component is affected?

Qwik Optimizer (rust)

Describe the bug

If I generate an NPM package with entry points as index.cjs, index.mjs, then the build breaks. They need to be named index.qwik.cjs and index.qwik.mjs exactly.

Reproduction

https://github.com/samijaber/qwik-import-bug-repro/tree/index.qwik.-removed

Steps to reproduce

branch: https://github.com/samijaber/qwik-import-bug-repro/tree/index.qwik.-removed

System Info

System:
    OS: macOS 12.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 89.09 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.13.0 - ~/.asdf/installs/nodejs/18.13.0/bin/node
    Yarn: 1.22.19 - ~/.asdf/installs/nodejs/18.13.0/bin/yarn
    npm: 8.19.3 - ~/.asdf/plugins/nodejs/shims/npm
    Watchman: 2023.05.08.00 - /opt/homebrew/bin/watchman
  Browsers:
    Brave Browser: 115.1.56.20
    Chrome: 115.0.5790.170
    Firefox: 109.0.1
    Safari: 15.2
  npmPackages:
    @builder.io/qwik: ^1.2.7 => 1.2.7 
    vite: ^4.4.9 => 4.4.9

Additional Information

No response

PatrickJS commented 1 month ago

@wmertens is this still an issue?

wmertens commented 2 weeks ago

I think it might be in the next release