search

QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.64k stars 1.28k forks source link

Type of RouteLocation['params'] incorrect #5343

Open blakeley opened 10 months ago

blakeley commented 10 months ago

https://github.com/BuilderIO/qwik/blob/374f25e7c2759651cffa652f2bd16241e53c9c24/packages/qwik-city/runtime/src/types.ts#L65

When navigating with a , params used on the page can temporarily be undefined. Navigation should either not render the current page with the next route's param values, or the type of params should be changed to be 

    readonly params: Readonly<Record<string, string | undefined>>;
mhevery commented 10 months ago

Good point, would you be willing to send a PR?