QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.7k stars 1.29k forks source link

[✨] end-to-end test of a production build #5798

Open wmertens opened 8 months ago

wmertens commented 8 months ago

Is your feature request related to a problem?

1.4.1 introduced a bug that made production builds fail to run.

Describe the solution you'd like

We need an e2e test that builds a test app on popular targets and verifies it works correctly.

Describe alternatives you've considered

the docs site is such a test app but the deploy to cloudflare worked, it was vercel that had an issue due to the deploy directory differing from the build location

Additional context

No response

PatrickJS commented 8 months ago

we should also check for each integration too the build can even work

colelawrence commented 7 months ago

I have a relatively complicated approach to trying to use Qwik City, and releases are always a seemingly huge gamble for me to adopt for fear of losing time. So, I end up deferring to staying on broken versions where I understand the parts that are broken rather than upgrading and risking breakages I am unfamiliar with.

wmertens commented 7 months ago

@colelawrence that's another way of saying that you have an awesome array of e2e tests that we should adopt. PRs welcome ;)

maiieul commented 1 month ago

@wmertens @PatrickJS hasn't this been done now?

JerryWu1234 commented 2 weeks ago

Is anyone trying this ?

JerryWu1234 commented 1 week ago

@wmertens @maiieul