QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.84k stars 1.31k forks source link

[🐞] Warning and errors when validating the generated HTML using Nu Html Checker #6175

Closed helabenkhalfallah closed 6 months ago

helabenkhalfallah commented 6 months ago

Which component is affected?

Qwik Runtime

Describe the bug

Hello, by validating the HTML generated using Nu Html Checker, it generates several warnings and errors:

The source code:

import { component$ } from '@builder.io/qwik';

export default component$(() => {
  return (
    <main>
      <h1>Qwik</h1>
      <section>
        <h2>Core features</h2>
        <p>
          Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. 
        </p>
      </section>
    </main>
  );
});

The generated HTML:

<!doctype html>
<html
  q:container="paused"
  q:version="1.5.2-dev20240418142224"
  q:render="ssr-dev"
  q:base="/repl/1lsst7gz46v/build/"
  q:manifest-hash="vhqpfk"
>
  <!--qv q:key=0t_1--><head q:head>
    <title q:head>Hello Qwik</title>
  </head>
  <body>
    <!--qv q:id=0 q:key=Ncbm:0t_0-->
    <main q:key="4e_0">
      <h1>Qwik</h1>
      <section>
        <h2>Core features</h2>
        <p>
          Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do
          eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad
          minim veniam, quis nostrud exercitation ullamco laboris nisi ut
          aliquip ex ea commodo consequat.
        </p>
      </section>
    </main>
    <!--/qv-->
  </body>
  <!--/qv-->
  <script type="qwik/json">
    {"refs":{},"ctx":{},"objs":[],"subs":[]}
  </script>
</html>

The playground link.

The W3C check results:

image image

I can also reproduce the same issues when analyzing the html of some websites using Qwik. image

Thank you so much for your help :) :)

Reproduction

https://qwik.dev/examples/introduction/hello-world/#f=7ZbBDoIwDIZfpQ9gNBoTL8aLV68%2BwAIzNmEMhPn8fh0g%2BAAeTLwN1nXr1n5%2FF0mzPxy%2BmTRjqIaPOdztaQiLwfRvxOAikPvudDaQ3Uj4BA4x3y2mm3kscsEQ2Wu6FGBVFWEAegAL%2B1V%2BChMtnIgrtdGusJbEV8okLGWBeE1diLDa200Ax0JLLXMPklXMzoEoZtcmtJBbqPg2ubVce%2FG1BnybEDN48unCStoE3%2BpIS5NKSOofhSI3lpJA24UiDp7NCO2wnbJLbTAW77LcRQ6XA2Crfi1z%2BJTf%2B40%2F7u64me7anvpfnz9Zny8

Steps to reproduce

Copy/paste the generated html in the Nu Html Checker.

System Info

I used the playground on chrome (Version 124.0.6367.61) and desktop.

Additional Information

No response

dejurin commented 6 months ago

This is a payment for the use of resumable.

But if a developer looks here, I'd like a parameter added that would remove the version number of the qwik.

PatrickJS commented 6 months ago

I made an issue in their repo https://github.com/validator/validator/issues/1722