QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.71k stars 1.29k forks source link

fix(qrl): help rollup resolve imports from qrl segments #6586

Closed wmertens closed 3 months ago

wmertens commented 3 months ago

It seems like Rollup only does its own nodejs-like resolving if a path exists on disk, even if only the filename doesn't exist.

also:

netlify[bot] commented 3 months ago

Deploy Preview for qwik-insights ready!

Name Link
Latest commit 3a3558c423e900a13fe9467726eff16f520cd95d
Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/667539839265c5000824efca
Deploy Preview https://deploy-preview-6586--qwik-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pkg-pr-new[bot] commented 3 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 3a3558c

@builder.io/qwik

``` npm i https://pkg.pr.new/@builder.io/qwik@6586 ```

@builder.io/qwik-city

``` npm i https://pkg.pr.new/@builder.io/qwik-city@6586 ```

eslint-plugin-qwik

``` npm i https://pkg.pr.new/eslint-plugin-qwik@6586 ```

create-qwik

``` npm i https://pkg.pr.new/create-qwik@6586 ```

cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3a3558c
Status: ✅  Deploy successful!
Preview URL: https://2444ff11.qwik-8nx.pages.dev
Branch Preview URL: https://fix-dev.qwik-8nx.pages.dev

View logs