QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.71k stars 1.29k forks source link

fix(v2): fix the same task duplicates in serialized state #6623

Closed Varixo closed 3 months ago

Varixo commented 3 months ago

This PR fixes task serialization and removes the same task duplicates

cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e6d400d
Status:🚫  Build failed.

View logs

shairez commented 3 months ago

@Varixo thanks!

This is the error from CF pages -

23:19:55.904 | > qwik-monorepo@2.0.0-0 build.packages.docs /opt/buildhome/repo
23:19:55.904 | > pnpm -C ./packages/docs/ run build
23:19:55.904 |  
23:19:56.351 |  
23:19:56.351 | > qwik-docs@0.0.1 build /opt/buildhome/repo/packages/docs
23:19:56.351 | > qwik build
23:19:56.351 |  
23:19:56.409 | node:internal/modules/cjs/loader:1147
23:19:56.409 | throw err;
23:19:56.409 | ^
23:19:56.409 |  
23:19:56.410 | Error: Cannot find module './dist/cli.cjs'
23:19:56.410 | Require stack:
23:19:56.410 | - /opt/buildhome/repo/packages/qwik/qwik-cli.cjs
23:19:56.410 | at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
23:19:56.410 | at Module._load (node:internal/modules/cjs/loader:985:27)
23:19:56.410 | at Module.require (node:internal/modules/cjs/loader:1235:19)
23:19:56.410 | at require (node:internal/modules/helpers:176:18)
23:19:56.410 | at Object.<anonymous> (/opt/buildhome/repo/packages/qwik/qwik-cli.cjs:3:14)
23:19:56.410 | at Module._compile (node:internal/modules/cjs/loader:1376:14)
23:19:56.411 | at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
23:19:56.411 | at Module.load (node:internal/modules/cjs/loader:1207:32)
23:19:56.411 | at Module._load (node:internal/modules/cjs/loader:1023:12)
23:19:56.411 | at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12) {
23:19:56.411 | code: 'MODULE_NOT_FOUND',
23:19:56.411 | requireStack: [ '/opt/buildhome/repo/packages/qwik/qwik-cli.cjs' ]
23:19:56.412 | }
23:19:56.412

is it known? can we merge regardless?

Varixo commented 3 months ago

@Varixo thanks!

This is the error from CF pages -

23:19:55.904 | > qwik-monorepo@2.0.0-0 build.packages.docs /opt/buildhome/repo
23:19:55.904 | > pnpm -C ./packages/docs/ run build
23:19:55.904 |  
23:19:56.351 |  
23:19:56.351 | > qwik-docs@0.0.1 build /opt/buildhome/repo/packages/docs
23:19:56.351 | > qwik build
23:19:56.351 |  
23:19:56.409 | node:internal/modules/cjs/loader:1147
23:19:56.409 | throw err;
23:19:56.409 | ^
23:19:56.409 |  
23:19:56.410 | Error: Cannot find module './dist/cli.cjs'
23:19:56.410 | Require stack:
23:19:56.410 | - /opt/buildhome/repo/packages/qwik/qwik-cli.cjs
23:19:56.410 | at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
23:19:56.410 | at Module._load (node:internal/modules/cjs/loader:985:27)
23:19:56.410 | at Module.require (node:internal/modules/cjs/loader:1235:19)
23:19:56.410 | at require (node:internal/modules/helpers:176:18)
23:19:56.410 | at Object.<anonymous> (/opt/buildhome/repo/packages/qwik/qwik-cli.cjs:3:14)
23:19:56.410 | at Module._compile (node:internal/modules/cjs/loader:1376:14)
23:19:56.411 | at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
23:19:56.411 | at Module.load (node:internal/modules/cjs/loader:1207:32)
23:19:56.411 | at Module._load (node:internal/modules/cjs/loader:1023:12)
23:19:56.411 | at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12) {
23:19:56.411 | code: 'MODULE_NOT_FOUND',
23:19:56.411 | requireStack: [ '/opt/buildhome/repo/packages/qwik/qwik-cli.cjs' ]
23:19:56.412 | }
23:19:56.412

is it known? can we merge regardless?

Yes. In the current state the docs are not building in v2, because of dependecies